Skip to content

GitLab

JPScore
JPScore
Closed
Opened by Mohcine Chraibi@chraibi1Owner

bug in test juelich_2 / all models fail juelich_2

An abs is missing in runtest_juelich_2.py, see diff:

--- a/Utest/juelich_tests/test_2/runtest_juelich_2.py
+++ b/Utest/juelich_tests/test_2/runtest_juelich_2.py
@@ -16,7 +16,7 @@ def runtest2(inifile, trajfile):
     fps, n, traj = parse_file(trajfile)
     evac_time = (max(traj[:, 1]) - min(traj[:, 1])) / float(fps)
     tolerance = 0.01
-    if (evac_time- must_time) > tolerance:
+    if abs(evac_time- must_time) > tolerance:
         logging.info("%s exits with FAILURE evac_time = %f (!= %f)"%(argv[0], evac_time, must_time))
         exit(FAILURE)
     else:

When patched all models fail the juelich_2 test, since the evacuation time is significantly lower than 10s (~ 9.5s for GCFM, ~ 5.5s for Tordeaux)