Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
JPScore
JPScore
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 92
    • Issues 92
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 3
    • Merge Requests 3
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • JuPedSim
  • JPScoreJPScore
  • Issues
  • #205

Closed
Open
Opened Jul 21, 2016 by Mohcine Chraibi@chraibi1Owner

bug in test juelich_2 / all models fail juelich_2

An abs is missing in runtest_juelich_2.py, see diff:

--- a/Utest/juelich_tests/test_2/runtest_juelich_2.py
+++ b/Utest/juelich_tests/test_2/runtest_juelich_2.py
@@ -16,7 +16,7 @@ def runtest2(inifile, trajfile):
     fps, n, traj = parse_file(trajfile)
     evac_time = (max(traj[:, 1]) - min(traj[:, 1])) / float(fps)
     tolerance = 0.01
-    if (evac_time- must_time) > tolerance:
+    if abs(evac_time- must_time) > tolerance:
         logging.info("%s exits with FAILURE evac_time = %f (!= %f)"%(argv[0], evac_time, must_time))
         exit(FAILURE)
     else:

When patched all models fail the juelich_2 test, since the evacuation time is significantly lower than 10s (~ 9.5s for GCFM, ~ 5.5s for Tordeaux)

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: jupedsim/jpscore#205