JPSeditor issueshttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues2019-06-14T14:23:08+02:00https://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/145Clean up jpsexit2019-06-14T14:23:08+02:00Tao ZhongClean up jpsexit* [ ] Refactoring writeCrossing and writeTransitions
* [ ] Deprecate jpsexit* [ ] Refactoring writeCrossing and writeTransitions
* [ ] Deprecate jpsexithttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/143Double Transitions2019-06-27T19:50:15+02:00Ghost UserDouble TransitionsWhen creating a geometry with doors, the transitions are (always) saved twice in the geometry file.When creating a geometry with doors, the transitions are (always) saved twice in the geometry file.v0.8.9Tao ZhongTao Zhonghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/142Update Cmakelist for windows building2019-06-18T11:05:51+02:00Tao ZhongUpdate Cmakelist for windows buildingIn windows, it can't be built with release modeIn windows, it can't be built with release modeTao ZhongTao Zhonghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/141Cannot compile v0.8.8 on MacOs 10.14.42019-05-23T13:51:20+02:00tobias schroedterCannot compile v0.8.8 on MacOs 10.14.4When I tried to compile the newest version of JPSeditor, I got the following error:
[cmake.out](/uploads/91ab5cce4d2d32b505518e335ee9bc0f/cmake.out)
```
-- The CXX compiler identification is AppleClang 10.0.1.10010046
-- Check for worki...When I tried to compile the newest version of JPSeditor, I got the following error:
[cmake.out](/uploads/91ab5cce4d2d32b505518e335ee9bc0f/cmake.out)
```
-- The CXX compiler identification is AppleClang 10.0.1.10010046
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- System ........................................ Darwin (18.5.0, x86_64)
-- Generating ................................... JPSeditor (0.8.7) -- Release
-- JPSeditor will be installed to /Applications
-- CMAKE_BINARY_DIR .............................. /Users/tobias/development/jupedsim/jpseditor/build-v0.8.8
-- CMAKE_SOURCE_DIR .............................. /Users/tobias/development/jupedsim/jpseditor
-- CMAKE_CURRENT_SOURCE_DIR ...................... /Users/tobias/development/jupedsim/jpseditor
-- CMAKE_RUNTIME_OUTPUT_DIRECTORY ................ /Users/tobias/development/jupedsim/jpseditor/build-v0.8.8/bin
-- EXECUTABLE_OUTPUT_PATH ........................ /Users/tobias/development/jupedsim/jpseditor/build-v0.8.8/bin
-- Performing Test COMPILER_SUPPORTS_CXX11
-- Performing Test COMPILER_SUPPORTS_CXX11 - Success
-- Performing Test COMPILER_SUPPORTS_CXX0X
-- Performing Test COMPILER_SUPPORTS_CXX0X - Success
-- Checking for C++11 compiler ................... yes
-- Searching for Qt version ...................... 5
-- Found Qt version .............................. 5.12.3
-- Working with Qt5
-- Release flags ................................. -std=c++11 , -O3 -DNDEBUG
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/tobias/development/jupedsim/jpseditor/build-v0.8.8
```
[make.out](/uploads/80f9cac20179eea1ccec88f7b312e42f/make.out)
```
Scanning dependencies of target JPSeditor_autogen
[ 1%] Automatic MOC for target JPSeditor
[ 1%] Built target JPSeditor_autogen
[ 3%] Generating ui_goalwidget.h
[ 5%] Generating qrc_resources.cpp
[ 7%] Generating ui_mainwindow.h
[ 9%] Generating ui_roomwidget.h
/Users/tobias/development/jupedsim/jpseditor/forms/roomwidget.ui: Warning: The name 'layoutWidget' (QWidget) is already in use, defaulting to 'layoutWidget1'.
/Users/tobias/development/jupedsim/jpseditor/forms/roomwidget.ui: Warning: The name 'layoutWidget' (QWidget) is already in use, defaulting to 'layoutWidget2'.
[ 11%] Generating ui_widgetlandmark.h
[ 12%] Generating ui_widgetsettings.h
[ 14%] Generating ui_settingdialog.h
[ 16%] Generating ui_inifilewidget.h
/Users/tobias/development/jupedsim/jpseditor/forms/inifilewidget.ui: Warning: The name 'layoutWidget' (QWidget) is already in use, defaulting to 'layoutWidget1'.
/Users/tobias/development/jupedsim/jpseditor/forms/inifilewidget.ui: Warning: The name 'layoutWidget' (QWidget) is already in use, defaulting to 'layoutWidget2'.
/Users/tobias/development/jupedsim/jpseditor/forms/inifilewidget.ui: Warning: The name 'layoutWidget' (QWidget) is already in use, defaulting to 'layoutWidget3'.
/Users/tobias/development/jupedsim/jpseditor/forms/inifilewidget.ui: Warning: The name 'layoutWidget' (QWidget) is already in use, defaulting to 'layoutWidget4'.
[ 18%] Generating ui_snappingoptions.h
[ 20%] Generating ui_sourcewidget.h
Scanning dependencies of target JPSeditor
[ 22%] Building CXX object CMakeFiles/JPSeditor.dir/JPSeditor_autogen/mocs_compilation.cpp.o
In file included from /Users/tobias/development/jupedsim/jpseditor/build-v0.8.8/JPSeditor_autogen/mocs_compilation.cpp:2:
/Users/tobias/development/jupedsim/jpseditor/build-v0.8.8/JPSeditor_autogen/M4YTXQ7V2H/moc_jpselementlistmodel.cpp:9:10: fatal error: '../../../../../../Documents/development/jupedsim/jpseditor/src/models/jpselementlistmodel.h' file not found
#include "../../../../../../Documents/development/jupedsim/jpseditor/src/models/jpselementlistmodel.h"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/JPSeditor.dir/JPSeditor_autogen/mocs_compilation.cpp.o] Error 1
make[1]: *** [CMakeFiles/JPSeditor.dir/all] Error 2
make: *** [all] Error 2
```https://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/140Better installer for win, linux and macOS2019-06-18T11:05:51+02:00Tao ZhongBetter installer for win, linux and macOSv0.8.9https://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/137Open file fails2019-06-03T10:22:42+02:00Mohcine Chraibim.chraibi@fz-juelich.deOpen file failsOpening this geometry gives the following error message, however after clicking "OK" the file opens correctly.
Besides, `jpseditor` also complains about failing sources and goals files: This is not necessary if the geometry does not hav...Opening this geometry gives the following error message, however after clicking "OK" the file opens correctly.
Besides, `jpseditor` also complains about failing sources and goals files: This is not necessary if the geometry does not have these files, then it's fine.
![Screenshot_2019-05-13_at_12.23.46](/uploads/3093e2ee2647f9ab60fca4b60f7cbdeb/Screenshot_2019-05-13_at_12.23.46.png)
![Screenshot_2019-05-13_at_12.24.09](/uploads/c676de436428f8f4ec72e3b6fb7d2e9c/Screenshot_2019-05-13_at_12.24.09.png)
[Raum_2_a.xml](/uploads/69441a38579834586af90fa4e424787b/Raum_2_a.xml)v0.8.9Tao ZhongTao Zhonghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/135Update ini file writer/reader for models2019-06-27T19:50:15+02:00Tao ZhongUpdate ini file writer/reader for modelsv0.8.9Tao ZhongTao Zhonghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/134Update ini file reader2019-06-27T19:50:15+02:00Tao ZhongUpdate ini file readerThe format of ini file is changed, the praser in JPSeditor must be updatedThe format of ini file is changed, the praser in JPSeditor must be updatedv0.8.8Tao ZhongTao Zhonghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/133Update goal file format2019-06-18T16:40:23+02:00Mohcine Chraibim.chraibi@fz-juelich.deUpdate goal file formatFor visualizing with `jpsvis` this change in the format is necessary (adding limits)
```
<goal id="1" final="true" caption="goal1" x_min="3.6" x_max="5.2" y_min="-4" y_max="-3">
```
See [here](http://www.jupedsim.org/jpscore/2019-04...For visualizing with `jpsvis` this change in the format is necessary (adding limits)
```
<goal id="1" final="true" caption="goal1" x_min="3.6" x_max="5.2" y_min="-4" y_max="-3">
```
See [here](http://www.jupedsim.org/jpscore/2019-04-12-goals)v0.8.8https://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/132Update about with useful information2019-05-27T14:01:17+02:00Mohcine Chraibim.chraibi@fz-juelich.deUpdate about with useful informationFor issue reports, it makes sense to send a screenshot of the used `jpseditor`.
See for example `jpsvis`
![Screenshot_2019-04-05_at_21.16.26](/uploads/1db32c2b10f02214d8ad6602918eabef/Screenshot_2019-04-05_at_21.16.26.png)
See these ...For issue reports, it makes sense to send a screenshot of the used `jpseditor`.
See for example `jpsvis`
![Screenshot_2019-04-05_at_21.16.26](/uploads/1db32c2b10f02214d8ad6602918eabef/Screenshot_2019-04-05_at_21.16.26.png)
See these lines:
- [line 340](https://gitlab.version.fz-juelich.de/jupedsim/jpsvis/blob/master/src/MainWindow.cpp#L340)
- [line 79](https://gitlab.version.fz-juelich.de/jupedsim/jpsvis/blob/master/src/MainWindow.cpp#L79)v0.8.9Tao ZhongTao Zhonghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/131Show/ hide options tab2019-06-27T19:50:15+02:00Mohcine Chraibim.chraibi@fz-juelich.deShow/ hide options tabHave a look at the video to get the idea :-)
![hide_show](/uploads/2ef7a75662409182d82b2cf15fff0d75/hide_show.mov)Have a look at the video to get the idea :-)
![hide_show](/uploads/2ef7a75662409182d82b2cf15fff0d75/hide_show.mov)v0.8.8Tao ZhongTao Zhonghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/129Format the name of xml files2019-06-27T19:50:15+02:00Tao ZhongFormat the name of xml filesv0.8.8Tao ZhongTao Zhonghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/128Better defaults2019-06-18T16:40:23+02:00Mohcine Chraibim.chraibi@fz-juelich.deBetter defaultsWhen an argument is not given, it's better not to set it at all.
For example `jpseditor` outputs this
```
<source id="1" frequency="0" N_create="10" percent="0" rate="0" time_min="0" time_max="0"
agents_max="100" gro...When an argument is not given, it's better not to set it at all.
For example `jpseditor` outputs this
```
<source id="1" frequency="0" N_create="10" percent="0" rate="0" time_min="0" time_max="0"
agents_max="100" group_id="5" caption="Source1" greedy="false" time="0" startX="0" startY="0" x_min="4.85"
x_max="5.97" y_min="25.14" y_max="26.1"/>
```
Better would be
```
<source id="1" frequency="0" N_create="10"
agents_max="100" group_id="5" caption="Source1" greedy="false" x_min="4.85"
x_max="5.97" y_min="25.14" y_max="26.1"/>
```v0.8.8Tao ZhongTao Zhonghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/127Combine data between geometry and inifile2019-06-18T16:40:23+02:00Tao ZhongCombine data between geometry and inifile- Goal
- Door
- Room- Goal
- Door
- Roomv0.8.8Tao ZhongTao Zhonghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/126XML file for traffic2019-06-18T16:40:23+02:00Ghost UserXML file for trafficSee issue [302](https://gitlab.version.fz-juelich.de/jupedsim/jpscore/issues/302) in jpscoreSee issue [302](https://gitlab.version.fz-juelich.de/jupedsim/jpscore/issues/302) in jpscorev0.8.8Tao ZhongTao Zhonghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/125XML file for transitions2019-04-03T21:26:34+02:00Tao ZhongXML file for transitionsv0.8.8Tao ZhongTao Zhonghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/123Merge door window into room2019-06-18T16:40:23+02:00Tao ZhongMerge door window into roomv0.8.8Tao ZhongTao Zhonghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/122Snapping options aren't save2019-06-18T16:40:23+02:00Tao ZhongSnapping options aren't saveSnapping options can't be saved after closing snapping widgetSnapping options can't be saved after closing snapping widgetv0.8.8Tao ZhongTao Zhonghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/121Segmentation Fault when opening empty rooms2019-03-06T11:15:35+01:00Mohcine Chraibim.chraibi@fz-juelich.deSegmentation Fault when opening empty roomsWhen opening rooms like this one (a backup file)
```
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<geometry version="0.8" caption="corner" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="ht...When opening rooms like this one (a backup file)
```
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<geometry version="0.8" caption="corner" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://xsd.jupedsim.org/jps_geometry.xsd" unit="m">
<rooms>
<room id="0" caption="floor">
<crossings/>
</room>
</rooms>
<transitions/>
<Undefine/>
</geometry>
```
a SegFault is produced.
We simply should expect these files and don't parse them at all.
![Screenshot_2019-02-14_at_09.55.22](/uploads/c7fc520461f1adb4c97153c64375bfa0/Screenshot_2019-02-14_at_09.55.22.png)v0.8.7Tao ZhongTao Zhonghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpseditor/-/issues/120Keystrok for Walls ist wrong2019-02-20T16:06:26+01:00Mohcine Chraibim.chraibi@fz-juelich.deKeystrok for Walls ist wrong![Screenshot_2019-02-14_at_09.48.45](/uploads/b71e27b206e49e3f6d4d69e995246358/Screenshot_2019-02-14_at_09.48.45.png)
![Screenshot_2019-02-14_at_09.48.51](/uploads/db31355c90ba717a127cc1c8bea71220/Screenshot_2019-02-14_at_09.48.51.png)![Screenshot_2019-02-14_at_09.48.45](/uploads/b71e27b206e49e3f6d4d69e995246358/Screenshot_2019-02-14_at_09.48.45.png)
![Screenshot_2019-02-14_at_09.48.51](/uploads/db31355c90ba717a127cc1c8bea71220/Screenshot_2019-02-14_at_09.48.51.png)v0.8.7Tao ZhongTao Zhong