JPScore issueshttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues2019-03-23T05:00:38+01:00https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/206Reduce execution time of tests2019-03-23T05:00:38+01:00Mohcine Chraibim.chraibi@fz-juelich.deReduce execution time of tests- juelich 11 (136.13 s)
- juelich 13 (1321.74 s)
- juelich_14 (1493 s)
- juelich 6 (372 s)
- juelich 8 (147 s)
- Rimea 9 (192 s)
- Rimea 13 (1570 s)- juelich 11 (136.13 s)
- juelich 13 (1321.74 s)
- juelich_14 (1493 s)
- juelich 6 (372 s)
- juelich 8 (147 s)
- Rimea 9 (192 s)
- Rimea 13 (1570 s)guido bastenguido basten2016-12-24https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/229merge toxicity_branch in develop2018-06-13T16:41:32+02:00Mohcine Chraibim.chraibi@fz-juelich.demerge toxicity_branch in developMohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.de2016-12-31https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/230Update links to documentation2018-06-13T16:41:33+02:00Mohcine Chraibim.chraibi@fz-juelich.deUpdate links to documentationPlease check all [documentation](http://www.jupedsim.org) pages and check if there still exist a link to the old `cst`-repository.
- Check the wiki pages. Images that have been uploaded are missing.
- Write a note here. What is mis...Please check all [documentation](http://www.jupedsim.org) pages and check if there still exist a link to the old `cst`-repository.
- Check the wiki pages. Images that have been uploaded are missing.
- Write a note here. What is missing. Aaron SchumacherAaron Schumacher2017-01-14https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/235Router Test Suite2018-06-13T16:41:29+02:00Arne GrafRouter Test SuitePlease upload for every test:
- the inifile
- the geometry file
- a file describing the result in the following format
| Router *id* | Test *id* | Comments |
| ----------- | --------- | -------------|
---
## Test 1:
- Author: Ke...Please upload for every test:
- the inifile
- the geometry file
- a file describing the result in the following format
| Router *id* | Test *id* | Comments |
| ----------- | --------- | -------------|
---
## Test 1:
- Author: Kemloh und Löhner
- Inifile:
- geometry:[test1.zip](/uploads/72304756c14a816f2c6fe9568cf0ad64/test1.zip)
---
## Test 2:
- Author: Löhner
- Inifile:
- geometry:[test2.zip](/uploads/ebb317f5bfdad6d3f25d0c0b849c90e3/test2.zip)
---
## Test 3:
- Author: @gutt1
- Inifile: [ini_Test3.xml](/uploads/20a6f62d1e6b302d48467eb671a71aa2/ini_Test3.xml)
- geometry:[geo_Test3.xml](/uploads/1633894e52aa62bd48d7ac867d5f5b3e/geo_Test3.xml)
- results:[res_Test3.ods](/uploads/b63b83177290ebd2c7bab26bd35f39dd/res_Test3.ods)
---
## Test 4:
- Author: @zhong1
- Inifile: [ini_Test4.xml](/uploads/0e90f5ac6423d7ac777e5490d30ebeca/ini_Test4.xml)
- geometry: [geo_Test4.xml](/uploads/b59056b6d4cec267093c33254c1f959d/geo_Test4.xml)
- results: [router_test_results_Test4.md](/uploads/39cff571f5368da97477f2b213e88b8f/router_test_results_Test4.md)
---
## Test 5:
- Author: @zhong1
- Inifile: [ini_Test5.xml](/uploads/749244f0927c8af82afad54667263784/ini_Test5.xml)
- geometry: [geo_Test5.xml](/uploads/413b0ce2056f903f3c9c98f3b4c655b6/geo_Test5.xml)
- results: [router_test_results_Test5.md](/uploads/ee3fc5671e14c7228f4f68ebe731b115/router_test_results_Test5.md)
---
## Test 6:
- Author: Crociani
- Inifile:
- geometry:[test6.zip](/uploads/8891322ba46264555cdd35f920e5d428/test6.zip)
---
## Test 7:
- Author: von Sivers
- Inifile:
- geometry:[test7.zip](/uploads/f9536e77164b44ca657ee42dba89275c/test7.zip)
---
## Test 8:
- Author: @gutt1
- Inifile:[ini_Test8.xml](/uploads/59616e0083924e68904a05b3da04ed71/ini_Test8.xml)
- geometry:[geo_Test8.xml](/uploads/bde779483ec145d29452b617fff6f1e8/geo_Test8.xml)
- results:[res_Test8.ods](/uploads/eecdfe87ed686297af82d60201dc19fa/res_Test8.ods)
---Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.de2017-03-04https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/332JURECA | header, logfile2019-07-04T08:06:58+02:00Ghost UserJURECA | header, logfile**jpscore**:
```
JuPedSim - JPScore
Current date : Jul 2 2019 19:07:41
Version : 0.8.4
Commit hash : v0.8.4-68-ga33375a
Commit date : Mon Jul 1 15:21:05 2019
Branch : develop
----
```
**inifile** in `/data`:
...**jpscore**:
```
JuPedSim - JPScore
Current date : Jul 2 2019 19:07:41
Version : 0.8.4
Commit hash : v0.8.4-68-ga33375a
Commit date : Mon Jul 1 15:21:05 2019
Branch : develop
----
```
**inifile** in `/data`:
```xml
<header>
<seed>4313</seed>
<max_sim_time>80</max_sim_time>
<num_threads>48</num_threads>
<show_statistics>true</show_statistics>
<logfile>log_RiMEA_Test_04_7-0_om_2</logfile>
<!--<progressbar/>-->
<trajectories format="plain" fps="2">
<file location="traj_RiMEA_Test_04_7-0_om_2.txt" />
</trajectories>
<geometry>geo_RiMEA_Test_04.xml</geometry>
</header>
...
```
**batch_script** in `$HOME`:
```batch
#!/bin/bash -x
#SBATCH -J R70
#SBATCH --account=ias-7
#SBATCH --nodes=1
#SBATCH --ntasks=1
#SBATCH --cpus-per-task=48
#SBATCH --output=data/out_%j.txt
#SBATCH --error=data/err_%j.txt
#SBATCH --time=6:00:00
#SBATCH --mail-user=g.jaeger@fz-juelich.de
#SBATCH --mail-type=ALL
export OMP_NUM_THREADS=${SLURM_CPUS_PER_TASK}
srun ./jpscore/bin/jpscore data/ini_RiMEA_Test_04_7-0_om_2.xml
```
The logfile is stored in the root directory (`$HOME`) as `datalog_RiMEA_Test_04_7-0_om_2.txt`. Also the statistic files are stored there.
Both files should be stored in the directory `data` (like the trajectory files).
**Note**:
The function `<progressbar/>` creates a very large file (5-15 GB) and should be disabled.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/331statistical distributions2019-06-24T19:37:53+02:00Ghost Userstatistical distributionsAt the moment, the pre-movement time is Gauss-distributed. The agent parameters are also.
I suggest that we implement more statistical distributions (for agent velocity and pre-movement time):
- no distribution
- uniform (min and max)...At the moment, the pre-movement time is Gauss-distributed. The agent parameters are also.
I suggest that we implement more statistical distributions (for agent velocity and pre-movement time):
- no distribution
- uniform (min and max)
- truncated normal (min, max, mean, sigma)
- normal (mean, sigma) - already exists
- triangular (min, max, mean)
- log-normal (min, max, mean, sigma, sigma_2)https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/330Writing Errors for WAs2019-06-24T13:03:42+02:00Ghost UserWriting Errors for WAsIn issue #327 we had to spend a lot of time to find our problem and in the end it was just one wrong letter in the definition of a waiting area.
As we have mentioned in #327 the simulation failed, without writing an error to the log-fil...In issue #327 we had to spend a lot of time to find our problem and in the end it was just one wrong letter in the definition of a waiting area.
As we have mentioned in #327 the simulation failed, without writing an error to the log-file. In the huge files for KapaKrit we might have 3.000 lines or more. Finding a typing error without any message in the log-file could take hours.
So, @schroedter1, is it possible to write such errors into the log? It does not have to be a very specified log-message, which tells you the specific line or something. But a small hint to see in which goal/waiting area the error occurs would be very helpful. Maybe by writing the goals id to the log.tobias schroedtertobias schroedterhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/329JPSreport: Err: The trajectory of ped with ID <1> is not continuous. Please m...2019-06-19T13:21:35+02:00Ghost UserJPSreport: Err: The trajectory of ped with ID <1> is not continuous. Please modify the trajectory file!## Summary
JPSreport does not finish its analyzis because "The trajectory of ped with ID <1> is not continuous.". The same error occurs for all IDs.
With a trajectory file from the JuPedSim demo folder this error does not occur. Traject...## Summary
JPSreport does not finish its analyzis because "The trajectory of ped with ID <1> is not continuous.". The same error occurs for all IDs.
With a trajectory file from the JuPedSim demo folder this error does not occur. Trajectories in trajectory file seem to be ok.
## Steps to reproduce
Windows 10, PowerShell
. ..\..\bin\jpsreport.exe ini_corridor_december.xml
## Inifile + Geometry file to reproduce bug
[ini_corridor_december.xml](/uploads/d4caed6c299041a2554e2f14a12188f8/ini_corridor_december.xml)
[geo_test2.xml](/uploads/991d5e7f7bb397764b22d488c368c448/geo_test2.xml)
[traj_100_N25_h0_R2.txt](/uploads/54c49306d5cd857d1ea824af67f1ed48/traj_100_N25_h0_R2.txt)
## Relevant logs, files (inifile and geometry) and/or screenshots
![PowerShell_JPSreport_DecemberExp](/uploads/cb6ce7a583354549b154de30c3ee46df/PowerShell_JPSreport_DecemberExp.jpg)https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/328track for trains question2019-06-27T09:25:38+02:00Tim Orthtrack for trains question## Question
I need some support with the tracks for trains feature.
I changed the class of the subroom to „Platform“ and set the type of the wall of the track to „track-1“ in the geometry.
Defined the start and end of the track in t...## Question
I need some support with the tracks for trains feature.
I changed the class of the subroom to „Platform“ and set the type of the wall of the track to „track-1“ in the geometry.
Defined the start and end of the track in train_time_table.xml with the coordinates of the „track-1“-wall.
```
Terminal message: Arrival:
TRAIN Desiro_HC at time: 30
enter with train Desiro_HC
Enter correctGeometry: Building Has 5 Transitions
room: 101 subroom_id 1
Error in GetIntersection. Should be 2 but got 1
```
1. Which element should have 2 intersections? The „track-1“-wall and the ttt track are from intersection 10/130 to 10/20. I think I’m missing something.
2. In addition: Can the track only be in/at one subroom? Because I get an error if the defined track in ttt uses more then one.
```
Error: Arrival: TRAIN Desiro_HC at time: 30 could not find any track! Exit.
```
Folder witch data for the main question: [files](https://1drv.ms/u/s!AsV6LgpLPxYhgbIanMfhzZ8QJLIXuw?e=tQSaw4)0.8.5Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/327Wating area testing 32019-06-24T13:03:43+02:00guido bastenWating area testing 3In this test 100 pedestrians are created with an `agents_source`.
After 50 distributed peds the simulation stops and doesn't show any Errors in the console.
In the Log file is also no explanation why the simulation stops at this point....In this test 100 pedestrians are created with an `agents_source`.
After 50 distributed peds the simulation stops and doesn't show any Errors in the console.
In the Log file is also no explanation why the simulation stops at this point.
![WA_console](/uploads/d2c97e4e79af62f7bc357d8a9a70ed90/WA_console.png)tobias schroedtertobias schroedterhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/326inifile, header, location for trajectory files2019-07-17T06:19:29+02:00Ghost Userinifile, header, location for trajectory filesThe file location definition (see [header](http://www.jupedsim.org/jpscore/2016-11-01-inifile.html#header)) is only considered for the first trajectory file.
```xml
<trajectories format="xml-plain" fps="8" color_mode="velocity">
<fi...The file location definition (see [header](http://www.jupedsim.org/jpscore/2016-11-01-inifile.html#header)) is only considered for the first trajectory file.
```xml
<trajectories format="xml-plain" fps="8" color_mode="velocity">
<file location="trajectories.xml" /> </trajectories>
```
The other files are stored in the folder of the ini-file.
(example: [geo_RiMEA_Test_04.xml](/uploads/e8d626b8cbbfb2359fc060cf6f531fc7/geo_RiMEA_Test_04.xml), [ini_RiMEA_Test_04_0-5.xml](/uploads/b6b8bcff88e241078336dbf60e9673f8/ini_RiMEA_Test_04_0-5.xml))https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/325inifile, header2019-06-24T09:30:40+02:00Ghost Userinifile, headerThe simulation *RiMEA_Test_04_0-5* does not run with `<header>` as described in the [documentation](http://www.jupedsim.org/jpscore/2016-11-01-inifile).
[ini_RiMEA_Test_04_0-5.xml](/uploads/34bb482701018f085dfb6f803c49eeb1/ini_RiMEA_Tes...The simulation *RiMEA_Test_04_0-5* does not run with `<header>` as described in the [documentation](http://www.jupedsim.org/jpscore/2016-11-01-inifile).
[ini_RiMEA_Test_04_0-5.xml](/uploads/34bb482701018f085dfb6f803c49eeb1/ini_RiMEA_Test_04_0-5.xml)
[geo_RiMEA_Test_04.xml](/uploads/4fd1cb5dc22914899a3045e653a28593/geo_RiMEA_Test_04.xml)https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/324Print Statistics2019-07-17T06:19:29+02:00Ghost UserPrint Statisticsfrom [Simulation.cpp, line 417 ff](https://gitlab.version.fz-juelich.de/jupedsim/jpscore/blob/develop/Simulation.cpp):
```c++
void Simulation::PrintStatistics(double simTime)
for (const auto& itr : _building->GetAllTransitions()) {
...from [Simulation.cpp, line 417 ff](https://gitlab.version.fz-juelich.de/jupedsim/jpscore/blob/develop/Simulation.cpp):
```c++
void Simulation::PrintStatistics(double simTime)
for (const auto& itr : _building->GetAllTransitions()) {
Transition* goal = itr.second;
if (goal->GetDoorUsage()) {
Log->Write(
"\nExit ID [%d] used by [%d] pedestrians. Last passing time [%0.2f] s",
goal->GetID(), goal->GetDoorUsage(),
goal->GetLastPassingTime());
string statsfile = "flow_exit_id_"+to_string(goal->GetID())+".txt";
if(goal->GetOutflowRate() < (std::numeric_limits<double>::max)())
{
char tmp[50];
sprintf(tmp, "%.2f", goal->GetOutflowRate());
statsfile = "flow_exit_id_"+to_string(goal->GetID())+"_rate_"+tmp+".txt";
}
Log->Write("More Information in the file: %s", statsfile.c_str());
{
auto statOutput = new FileHandler(statsfile.c_str());
statOutput->Write("#Simulation time: %.2f", simTime);
statOutput->Write("#Flow at exit "+goal->GetCaption()+"( ID "+to_string(goal->GetID())+" )");
statOutput->Write("#Time (s) cummulative number of agents \n");
statOutput->Write(goal->GetFlowCurve());
statOutput->FileHandler::~FileHandler();
}
}
}
```
Can we change the filename `flow_exit_id_` in line [430](https://gitlab.version.fz-juelich.de/jupedsim/jpscore/blob/develop/Simulation.cpp#L430) like the trajectory filename (e.g. `flow_exit_id_filename.txt`?https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/323ff_global_shortest_trips for trains2019-06-12T15:52:36+02:00Ghost Userff_global_shortest_trips for trainsThe router ff_global_shortest_trips needs to be able to use the dynamic trains from #300.The router ff_global_shortest_trips needs to be able to use the dynamic trains from #300.Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/322Waiting area on platform2019-06-12T15:48:19+02:00Ghost UserWaiting area on platformIf there are no doors on the platform the agents should go to the waiting are and wait.
![Screenshot_2019-06-12_15.41.53](/uploads/940996ae0294f50c2cf5fefce3bc5dac/Screenshot_2019-06-12_15.41.53.png)
Or the room (and subroom) has ...If there are no doors on the platform the agents should go to the waiting are and wait.
![Screenshot_2019-06-12_15.41.53](/uploads/940996ae0294f50c2cf5fefce3bc5dac/Screenshot_2019-06-12_15.41.53.png)
Or the room (and subroom) has to be defined as (final) goal.tobias schroedtertobias schroedterhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/321Elevators2019-05-20T12:14:10+02:00Ghost UserElevatorsWe have stairs and escalators, but we should also have elevators.We have stairs and escalators, but we should also have elevators.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/320One-sided closed doors2019-05-19T10:50:03+02:00tobias schroedterOne-sided closed doorsAllows to pedestrian to go through in one direction but is (temp) closed from the other direction.Allows to pedestrian to go through in one direction but is (temp) closed from the other direction.tobias schroedtertobias schroedterhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/319malloc_error_break2019-05-11T18:02:05+02:00Ghost Usermalloc_error_breakThe error of issue #316 is gone, but there is another error, now...
![Bildschirmfoto_2019-05-11_um_17.39.04](/uploads/a715b6ac39de47efd527de0aaef42db4/Bildschirmfoto_2019-05-11_um_17.39.04.png)
[correct_Bahnsteige.xml](/uploads/bfb68e5...The error of issue #316 is gone, but there is another error, now...
![Bildschirmfoto_2019-05-11_um_17.39.04](/uploads/a715b6ac39de47efd527de0aaef42db4/Bildschirmfoto_2019-05-11_um_17.39.04.png)
[correct_Bahnsteige.xml](/uploads/bfb68e52ecd861ba2ea16efd02a2e33b/correct_Bahnsteige.xml)
[log-goal.txt](/uploads/2e71bfd86980ea60c03f89cda3d96d45/log-goal.txt)
[Personen_ini.xml](/uploads/26c7559ed1e1b4e2695fcad5685ec12b/Personen_ini.xml)
I do another simulation to see if the error occurs again.
For the small setup (Aufgabe6 - #316) there is no problem anymore.Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/318Building jpscore on windows102019-06-02T14:35:00+02:00Ghost UserBuilding jpscore on windows10## Summary
Build of jpscore not possible.
## Steps to reproduce
http://www.jupedsim.org/jpscore/2018-10-21-windows
## Expected behavior
Build
## Actual behavior
Errors during build in Simulation.cpp and Makros.h
## Relevant logs,...## Summary
Build of jpscore not possible.
## Steps to reproduce
http://www.jupedsim.org/jpscore/2018-10-21-windows
## Expected behavior
Build
## Actual behavior
Errors during build in Simulation.cpp and Makros.h
## Relevant logs, files (inifile and geometry) and/or screenshots
Platform:
- Host: Windows10.0.17763AMD64
- CMake: 3.14.2
- CMake generator: Visual Studio 16 2019
- CMake build tool: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/MSBuild/Current/Bin/MSBuild.exe
- MSVC: 1920https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/317Logger2019-05-10T15:35:32+02:00tobias schroedterLoggerIssue for collecting ideas for logging librariesIssue for collecting ideas for logging libraries