JPScore issueshttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues2018-06-13T16:29:02+02:00https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/117Transition to/from stairs2018-06-13T16:29:02+02:00Mohcine Chraibim.chraibi@fz-juelich.deTransition to/from stairsThe transition from or to stairs is not smooth.
We need to know the elevation of the pedestrian relatively to the subroom he came from.The transition from or to stairs is not smooth.
We need to know the elevation of the pedestrian relatively to the subroom he came from.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/110make ini2018-06-13T16:29:02+02:00Mohcine Chraibim.chraibi@fz-juelich.demake inishould consider changing similar attributes of different tags
For example:
```
<v0 mu="[0.8, 1.0, 1.2]" sigma="0.0"/>
<bmax mu="[1,2]" sigma="0.001" />
```should consider changing similar attributes of different tags
For example:
```
<v0 mu="[0.8, 1.0, 1.2]" sigma="0.0"/>
<bmax mu="[1,2]" sigma="0.001" />
```https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/115Bug in strategy 42018-06-13T16:29:02+02:00Mohcine Chraibim.chraibi@fz-juelich.deBug in strategy 4test 8 fails, because of this bug.
![0005](https://cst.version.fz-juelich.de/jupedsim/jpscore/uploads/def353b80c8cfc6fbf668e3196286280/0005.png)test 8 fails, because of this bug.
![0005](https://cst.version.fz-juelich.de/jupedsim/jpscore/uploads/def353b80c8cfc6fbf668e3196286280/0005.png)Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/8InitGlobalRouter()2018-06-13T16:29:17+02:00Mohcine Chraibim.chraibi@fz-juelich.deInitGlobalRouter()What a monster function is that?
From line 79 - to line 459!!
Is it possible to rewrite this function in such a way that iit becomes readble?What a monster function is that?
From line 79 - to line 459!!
Is it possible to rewrite this function in such a way that iit becomes readble?https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/25Exit success or failure2018-06-13T16:29:17+02:00Mohcine Chraibim.chraibi@fz-juelich.deExit success or failureDo not exit within the code. Just send an ERROR to Log and exits once in main,Do not exit within the code. Just send an ERROR to Log and exits once in main,https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/78change software version to 0.62018-06-13T16:29:17+02:00Mohcine Chraibim.chraibi@fz-juelich.dechange software version to 0.6jpscore and jpsreport should work with inifile version >=0.5jpscore and jpsreport should work with inifile version >=0.5Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/73Router can not see the exit2018-06-13T16:29:17+02:00Mohcine Chraibim.chraibi@fz-juelich.deRouter can not see the exitRelated to the ini-file in commit 90904f317
```
WARNING: you have obstacles in room [0] Subroom [0]!
you might consider addin...Related to the ini-file in commit 90904f317
```
WARNING: you have obstacles in room [0] Subroom [0]!
you might consider adding extra hlines in your routing.xml file
```
This should not occur, since the triangulation is activated.
The following messages are output:
```
--------> Dumping AP <-----------
Friendly ID: cross_1_room_21_subroom_0 centre = [ 364.028, 771.57 ]
Real ID: 339
Is final exit to outside :0
Distance to final goals
[ -1, 0 m ]
transit to final goals:
connected to aps :
[ 989040_hline_363_room_21_subroom_0 , 5.44218 m ]
[ 989044_hline_364_room_21_subroom_0 , 6.57114 m ]
queue [ ]
------------------------------
Friendly ID: trans_22_room_1_subroom_0 centre = [ 415.948, 701.326 ]
Real ID: 526
Is final exit to outside :0
Distance to final goals
transit to final goals:
to UID ---> [ -1 ] ---> [ Nothing ]
connected to aps :
[ 525_trans_21_room_1_subroom_0 , 23.5411 m ]
[ 537_trans_33_room_1_subroom_0 , 84.4188 m ]
[ 538_trans_34_room_1_subroom_0 , 90.9343 m ]
[ 543_trans_39_room_1_subroom_0 , 106.675 m ]
[ 544_trans_40_room_1_subroom_0 , 115.268 m ]
[ 545_trans_41_room_1_subroom_0 , 114.113 m ]
[ 586_trans_82_room_1_subroom_0 , 104.988 m ]
[ 600_trans_96_room_1_subroom_0 , 70.2329 m ]
[ 987987_hline_114_room_1_subroom_0 , 115.757 m ]
[ 988140_hline_156_room_1_subroom_0 , 118.988 m ]
[ 988144_hline_157_room_1_subroom_0 , 119.546 m ]
[ 988156_hline_160_room_1_subroom_0 , 118.1 m ]
[ 988199_hline_167_room_1_subroom_0 , 95.0185 m ]
[ 988219_hline_172_room_1_subroom_0 , 92.6848 m ]
[ 988223_hline_173_room_1_subroom_0 , 90.9197 m ]
[ 988252_hline_181_room_1_subroom_0 , 71.4165 m ]
[ 988330_hline_202_room_1_subroom_0 , 20.0394 m ]
[ 988334_hline_203_room_1_subroom_0 , 18.5882 m ]
[ 988952_hline_344_room_15_subroom_0 , 8.48219 m ]
[ 988956_hline_345_room_15_subroom_0 , 10.6768 m ]
queue [ ]
```https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/40Reaction time2018-06-13T16:29:17+02:00Mohcine Chraibim.chraibi@fz-juelich.deReaction timeAdd reaction times for pedestriansAdd reaction times for pedestrianshttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/7GlobalRouter exits2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.deGlobalRouter exitsGlobalRouter should not quit when the final Exit is not visible.
Maybe a warning is enough.
Example: Corner - One Room - One Exit. Here the exit is not yet visible, but that is fine. The Router should not panik and quit the simulation.GlobalRouter should not quit when the final Exit is not visible.
Maybe a warning is enough.
Example: Corner - One Room - One Exit. Here the exit is not yet visible, but that is fine. The Router should not panik and quit the simulation.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/6Exit strategies2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.deExit strategiesAll exit strategies (choosing the direction of the desired velocity) should be combined in a unique usable strategy.
One approach can be to adapt the strategy to the length of the portal.All exit strategies (choosing the direction of the desired velocity) should be combined in a unique usable strategy.
One approach can be to adapt the strategy to the length of the portal.Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/36Test 12 fails: Visibility forces2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.deTest 12 fails: Visibility forcesPedestrians interact even through walls and obstacles.Pedestrians interact even through walls and obstacles.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/34Test 8 fails2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.deTest 8 failshttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/33Test 7 fails2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.deTest 7 failshttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/32Help section2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.deHelp sectionRewrite the Help and command line parsing section.
Allowed should be:
jpscore.exe ini.xml
jpscore.exe --help [-h]
jpscore.exe --version [-v]
Do we still need the "--inifile/ --ini" since we only take input files as arguments?Rewrite the Help and command line parsing section.
Allowed should be:
jpscore.exe ini.xml
jpscore.exe --help [-h]
jpscore.exe --version [-v]
Do we still need the "--inifile/ --ini" since we only take input files as arguments?https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/49more statistics: evacuation time for rooms2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.demore statistics: evacuation time for roomsgenerate more statistics at the end of the simulation.
Option to display them can be specified from the inputfilegenerate more statistics at the end of the simulation.
Option to display them can be specified from the inputfilehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/47Default files2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.deDefault filesrun `jpscore` without parameters should consider using the default files in `inputfiles/Default`run `jpscore` without parameters should consider using the default files in `inputfiles/Default`Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/44Turning parameter2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.deTurning parameterMohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/43Events management2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.deEvents managementAnkeAnkehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/41Information sharing2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.deInformation sharingPedestrians share their knowledge.Pedestrians share their knowledge.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/37for iteration over double value2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.defor iteration over double valueIn JPScore Simulation.cpp line 421
double t=0.0;
is then used as iteration variable in
for (t = 0; t < _tmax && _nPeds > 0; ++frameNr) {
...
}
which is likely to cause some errors. Better use a while-iteration.In JPScore Simulation.cpp line 421
double t=0.0;
is then used as iteration variable in
for (t = 0; t < _tmax && _nPeds > 0; ++frameNr) {
...
}
which is likely to cause some errors. Better use a while-iteration.