JPScore issueshttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues2018-03-16T15:01:02+01:00https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/196log file now mandatory?2018-03-16T15:01:02+01:00Mohcine Chraibim.chraibi@fz-juelich.delog file now mandatory?I encountered problems with calculating some of the demo inis.
However, I've found out that ```<logfile>log</logfile>``` may neither be commented out nor left empty.
Is this a desired behaviour?
If yes, we should update the ini files....I encountered problems with calculating some of the demo inis.
However, I've found out that ```<logfile>log</logfile>``` may neither be commented out nor left empty.
Is this a desired behaviour?
If yes, we should update the ini files.
If not, has anyone changed something that may related to that issue?Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/199bug with high num_threads (2/2): Wrong 'index' in CBuiling::GetRoom() Room ID2018-03-16T15:01:02+01:00Mohcine Chraibim.chraibi@fz-juelich.debug with high num_threads (2/2): Wrong 'index' in CBuiling::GetRoom() Room IDI've encountered severe issues, when increasing num_threads to higher orders e.g. 24.
Despite I have carefully checked my geometry file, I randomly get the following error:
```Wrong 'index' in CBuiling::GetRoom() Room ID: 576157584 size...I've encountered severe issues, when increasing num_threads to higher orders e.g. 24.
Despite I have carefully checked my geometry file, I randomly get the following error:
```Wrong 'index' in CBuiling::GetRoom() Room ID: 576157584 size: 20
Control your rooms ID and make sure they are in the order 0, 1, 2,..```
The very concerning thing is that this somehow depends on num_threads. When using num_threads=24 it works. With 12 it does not.
@Arne @OSchmidts @chraibi Does someone of you have an idea about that? FYI: The Hermes Cluster is available again and could be used for reproducing that. I've attached exemplary files.
[room_id.zip](/uploads/9a79fdcf65b24033849a3f9ca29108f4/room_id.zip)Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/238IsInSubroom() only works for polygons which only contain horizontal / vertica...2018-03-16T15:01:02+01:00Arne GrafIsInSubroom() only works for polygons which only contain horizontal / vertical lines.## Summary
https://en.wikipedia.org/wiki/Point_in_polygon
https://en.wikipedia.org/wiki/Winding_number
The algorithm checks,in which quadrant the nodes of the polygon are, where the position of the pedestrian/point was the origin of...## Summary
https://en.wikipedia.org/wiki/Point_in_polygon
https://en.wikipedia.org/wiki/Winding_number
The algorithm checks,in which quadrant the nodes of the polygon are, where the position of the pedestrian/point was the origin of the coordinate system.
Then, these quadrant numbers (1 .. 4) are added up and you can find, if a polygon is inside or outside.
It works not, if the polygon has edges, that are neither vertical nor horizontal. Please try it with pen and paper.
I will add a scanned picture some time soon.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/264Rooms as goals2018-01-25T17:26:16+01:00benjamin moehringRooms as goals## Question
Can I also define rooms as goals? The documentation says I can't place goals inside rooms. How can I otherwise have sources and goals within the same area?
[documentation](http://www.jupedsim.org/jpscore/2016-11-01-inifile....## Question
Can I also define rooms as goals? The documentation says I can't place goals inside rooms. How can I otherwise have sources and goals within the same area?
[documentation](http://www.jupedsim.org/jpscore/2016-11-01-inifile.html#goals)
*Additional goals might be defined outside the geometry. They should NOT overlap with any walls or be inside rooms. It is recommended to position them near the exits.*
Thank you, Bennihttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/258event-based injection of agents2018-01-25T17:10:34+01:00benjamin moehringevent-based injection of agents## Short description of suggestion
Hello JuPedSim,
I am looking for a possibility to inject agents at a specific time with specific plans (time, origin, goal) from a separate file.
The agents.xml file ideally contains agents (unique `...## Short description of suggestion
Hello JuPedSim,
I am looking for a possibility to inject agents at a specific time with specific plans (time, origin, goal) from a separate file.
The agents.xml file ideally contains agents (unique `agent_id` and `agent_parameter_id`) and plans (an agent, as I see it, can have more than one plan if he re-enters the simulation. This is not mandatory though. One can still split the input into different agents).
```
<agents operational_model_id="3">
<agents_distribution>
<group group_id="1" agents_file="agents.xml" router_id="4" />
<group group_id="2" agent_parameter_id="2" room_id="0" subroom_id="5" number=10 goal_id="-1" router_id="4" />
</agents_distribution>
</agents>
```
```
<!--plans file -->
<agents>
<agent agent_id="1" agent_parameter_id="1">
<plan time="186" room_id="0" subroom_id="0" goal_id="3"/>
</agent>
<agent agent_id="1" agent_parameter_id="1">
<plan time="1756" room_id="0" subroom_id="0" goal_id="-1"/>
</agent>
<agent agent_id="2" agent_parameter_id="2">
<plan time="295" room_id="0" subroom_id="0" goal_id="3"/>
<plan time="1455" room_id="0" subroom_id="0" goal_id="1"/>
</agent>
</agents>
```
The only two parameters I added to the existing data structure are
`agent_id` = unique id describing the agent. Should be written to the trajectory-file.
`time = ..` e.g. seconds after simulation start, defining when agents are injected.
## Why would the enhancement be useful to most users
This would allow users to easily translate external data-sources into JPS-agents and run their simulations with detailed input-data.0.8.3https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/263Can't compile on linux! Wrong boost version?2018-01-24T10:34:58+01:00Ghost UserCan't compile on linux! Wrong boost version?`PedDistributor.cpp`
In member function ‘const std::vector<Point> PedDistributor::GetPositionsFromFile(std::string, int, std::string) const’:
pedestrian/PedDistributor.cpp:456:61:
error: no matching function for call to
`combine(std...`PedDistributor.cpp`
In member function ‘const std::vector<Point> PedDistributor::GetPositionsFromFile(std::string, int, std::string) const’:
pedestrian/PedDistributor.cpp:456:61:
error: no matching function for call to
`combine(std::vector<int>&, std::vector<int>&, std::vector<double>&, std::vector<double>&)`
`for (auto tup : boost::combine(ids, frames, xpos, ypos))` https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/262validating geometry files2018-01-18T16:39:18+01:00benjamin moehringvalidating geometry files## Question
As mentioned in my last issue i am writting a code to create jps-geometries. To validate my output i am using jpsvis. Usually file errors are well documented in the log file. I'm having problems with an example network, that...## Question
As mentioned in my last issue i am writting a code to create jps-geometries. To validate my output i am using jpsvis. Usually file errors are well documented in the log file. I'm having problems with an example network, that I created for my home village Meckesheim though.
jpsvis opens the file without errors and visualizes the content, including the transitions. When viewing the geometry structure it crashes though. No logfile iswritten.
Do you know possible reasons for the crash? Are there other ways to validate my geometry file before opening it in JPS?
Thank you, Benni
## File
[MeckesheimJPSOut.xml](/uploads/0e753401e32b7485081a29bbd739991c/MeckesheimJPSOut.xml)
## Screenshots
![image](/uploads/dd52b4a79822bbda8d4c0289fd0c9879/image.png)
![image](/uploads/3b0410c89dd401f90d40a71fdaa0e7e2/image.png)
https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/255Simulation outcome not different when using jpsfire2017-12-28T11:16:09+01:00Ben HeinSimulation outcome not different when using jpsfireSpecifying jpsfire in the inifile like this for example:
`<JPSfire>
<A_smoke_sensor smoke_factor_grids="../FDS/3_sfgrids/" update_time="20" final_time="100" />
</JPSfire>`
with specific risk tolerances (`risk_tolerance_alpha="3.0" ris...Specifying jpsfire in the inifile like this for example:
`<JPSfire>
<A_smoke_sensor smoke_factor_grids="../FDS/3_sfgrids/" update_time="20" final_time="100" />
</JPSfire>`
with specific risk tolerances (`risk_tolerance_alpha="3.0" risk_tolerance_beta="12.0"`)
will not yield different simulation outcomes (the agents behave as if there were no sensor and take the shortest path).
However, I remember it working when the file input took place under the sensor section. Maybe they are not probably incorporated now...https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/260Walking speed is not activated when specifying in JPSfire section of ini file2017-12-25T02:44:10+01:00Ben HeinWalking speed is not activated when specifying in JPSfire section of ini file## Summary
This if statement, which should activate the walking speed reduction, is not executed when Walking Speed is specified in the ini file.
` if(_WalkingSpeed && _WalkingSpeed->ReduceWalkingSpeed()) {
std::cout << "...## Summary
This if statement, which should activate the walking speed reduction, is not executed when Walking Speed is specified in the ini file.
` if(_WalkingSpeed && _WalkingSpeed->ReduceWalkingSpeed()) {
std::cout << "JPSfire?" << std::endl;
walking_speed = _WalkingSpeed->WalkingInSmoke(this, walking_speed);`
## Steps to reproduce
Activate in any ini file to see that WalkingSpeed is not executed.
## Expected behavior
Walking speed reduction of agents.
## Actual behavior
no behaviour at allMohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/251Could not parse the project file2017-11-14T10:00:30+01:00Ghost UserCould not parse the project fileWhen starting Jpscore and when trying to run a simulation I get the messages:
ERROR: Failed to open file
ERROR: Could not parse the project fileWhen starting Jpscore and when trying to run a simulation I get the messages:
ERROR: Failed to open file
ERROR: Could not parse the project filehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/254Supported MacOS Version2017-10-29T08:27:49+01:00Ghost UserSupported MacOS VersionWhich Mac versions are supported (El Capitan, Sierra, High Sierra)?Which Mac versions are supported (El Capitan, Sierra, High Sierra)?https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/253Cognitive Map: Wrong value for routing strategy ERROR2017-10-17T16:29:31+02:00Ben HeinCognitive Map: Wrong value for routing strategy ERRORWhen using the cognitive map router as follows (for smoke sensor)
` <router router_id="7" description="cognitive_map">
<sensors>
<sensor sensor_id="2" description="Smoke" smoke_factor_grids="../FDS/3_sfgrids/dx_1.00/Z_2....When using the cognitive map router as follows (for smoke sensor)
` <router router_id="7" description="cognitive_map">
<sensors>
<sensor sensor_id="2" description="Smoke" smoke_factor_grids="../FDS/3_sfgrids/dx_1.00/Z_2.25/" update_time="20" final_time="120" status="activated"/>
<sensor sensor_id="3" description="LastDestination" status="activated"/>
</sensors>
<cognitive_map status="complete" />
</router>`
I get the following error when running jpscore:
**ERROR: wrong value for routing strategy [cognitive_map]!!!**
Have these values been changed/ is this due to the refactoring?https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/200bug with high num_threads (1/2): simulation not deterministic anymore2017-05-19T08:58:40+02:00Mohcine Chraibim.chraibi@fz-juelich.debug with high num_threads (1/2): simulation not deterministic anymoreI've encountered severe issues, when increasing num_threads to higher orders e.g. 24.
An ini-file with no changes at all including constant seed does not yield reproducible results. See screenshot.
![image](/uploads/cccb9501c07762896cc7...I've encountered severe issues, when increasing num_threads to higher orders e.g. 24.
An ini-file with no changes at all including constant seed does not yield reproducible results. See screenshot.
![image](/uploads/cccb9501c07762896cc705f57ead2072/image.png)
@Arne @OSchmidts @chraibi Does someone of you have an idea about that? FYI: The Hermes Cluster is available again and could be used for reproducing that. I've attached exemplary files in #199.Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/212Corret: Jenkins BOOST path2017-05-19T08:58:40+02:00Mohcine Chraibim.chraibi@fz-juelich.deCorret: Jenkins BOOST pathMohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/222Compiling error2017-05-19T08:58:39+02:00Mohcine Chraibim.chraibi@fz-juelich.deCompiling errorHello,
I get the attached error when compiling on opensuse 13.1 with gcc 4.8.3.
It would be great, if you have a suggestion how to fix this.
Thank you!
Best Regards
Fabian
[log_error](/uploads/5e176a33e7fee5eb60ae2da3e8bd276b/log_erro...Hello,
I get the attached error when compiling on opensuse 13.1 with gcc 4.8.3.
It would be great, if you have a suggestion how to fix this.
Thank you!
Best Regards
Fabian
[log_error](/uploads/5e176a33e7fee5eb60ae2da3e8bd276b/log_error)
[CMakeCache.txt](/uploads/b68c1dffba1dbc9dd55ebaba290948fa/CMakeCache.txt)https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/223I've been compiled the Jpscore in visual studio 2013,but I got an error about...2017-05-19T08:58:39+02:00Mohcine Chraibim.chraibi@fz-juelich.deI've been compiled the Jpscore in visual studio 2013,but I got an error about the OpenMP![image](/uploads/29a22382295a0ded6dec0133b37541a4/image.png)
Can I just using "int" instead "size_t", I got that the VS2013 only support the OpenMP 2.0, and the OpenMP 2.0 doesn't allow the unsigned int in sentence "for".![image](/uploads/29a22382295a0ded6dec0133b37541a4/image.png)
Can I just using "int" instead "size_t", I got that the VS2013 only support the OpenMP 2.0, and the OpenMP 2.0 doesn't allow the unsigned int in sentence "for".https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/224Compile errors under Windows (CLion)2017-05-19T08:58:39+02:00Mohcine Chraibim.chraibi@fz-juelich.deCompile errors under Windows (CLion)![image](/uploads/2d71c06ae350827026ad2084f155ca5d/image.png)![image](/uploads/2d71c06ae350827026ad2084f155ca5d/image.png)https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/225Strategy 8 on Stairs2017-05-19T08:58:39+02:00Mohcine Chraibim.chraibi@fz-juelich.deStrategy 8 on StairsApparently Str 8 doe not work on Stairs.
Are the [restrictions](http://www.jupedsim.org/jpscore/2016-11-03-routing) formulated for the `ffrouter` the same for this strategy?Apparently Str 8 doe not work on Stairs.
Are the [restrictions](http://www.jupedsim.org/jpscore/2016-11-03-routing) formulated for the `ffrouter` the same for this strategy?Arne GrafArne Grafhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/228The Euler scheme problem2017-05-19T08:58:39+02:00Mohcine Chraibim.chraibi@fz-juelich.deThe Euler scheme problemI got a problem about the computation of the Euler scheme, e.g. in GCFM model, the equation is
![image](/uploads/9ff0e42a3be3ea0fae1e68b3b8854e77/image.png)
![image](/uploads/9fa1b4195c2fafcdcfd44b2f9c492b8e/image.png)
if I use the v(t...I got a problem about the computation of the Euler scheme, e.g. in GCFM model, the equation is
![image](/uploads/9ff0e42a3be3ea0fae1e68b3b8854e77/image.png)
![image](/uploads/9fa1b4195c2fafcdcfd44b2f9c492b8e/image.png)
if I use the v(t) instead R(t) in the first equation, does this turn to be a first order ODE?
and I think Euler scheme is using to solve the first order ODE, and How to using it to solve the second order ODE.
Is there a derivation about how to using Euler scheme solve the first equation?
Thank you!https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/243Router error: could not find a route for pedestrian2017-05-19T08:58:39+02:00Tao ZhongRouter error: could not find a route for pedestrian## Summary
With the router "**ff_global_shortest**" there is a error and intermit the simulation in JPScore, but it works with "**global shortest**" router.
## Inifile + Geometry file to reproduce bug
inifile: [ini_Test4.xml](/uploads/c...## Summary
With the router "**ff_global_shortest**" there is a error and intermit the simulation in JPScore, but it works with "**global shortest**" router.
## Inifile + Geometry file to reproduce bug
inifile: [ini_Test4.xml](/uploads/c4f1a7cc04b57fc8ea64c293fbf76fc4/ini_Test4.xml)
geometry: [geo_Test4.xml](/uploads/4a409dd6df18592613ed88fb18863505/geo_Test4.xml)
## Actual behavior
Run the inifile, the simulation will stop and reports a segmentation fault by the 47.5%.
## Relevant logs, files (inifile and geometry) and/or screenshots
Error: ![屏幕快照_2017-03-10_14.51.11](/uploads/e4df6c2700a1c15b79197a19b6a8d008/屏幕快照_2017-03-10_14.51.11.png)
log: [Test4_log.txt.P0.dat](/uploads/f16b836be90041261dfc5896bc4e2b76/Test4_log.txt.P0.dat)Arne GrafArne Graf