JPScore issueshttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues2018-01-19T15:00:01+01:00https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/261osm-convert: creating geometries from open data2018-01-19T15:00:01+01:00benjamin moehringosm-convert: creating geometries from open data## Short description of suggestion
Hello, I am currently developing a tool to convert openstreetmap data into jps-readable geometry.xml files.
You can check out the current version of my python code from https://github.com/bsmoehring/jps...## Short description of suggestion
Hello, I am currently developing a tool to convert openstreetmap data into jps-readable geometry.xml files.
You can check out the current version of my python code from https://github.com/bsmoehring/jpsTools
To be honest the code might still be unhandy for someone who didn't write it. But I provided some example datasets in https://github.com/bsmoehring/jpsTools/tree/master/jpsTools/osmImport/resources
## Why would the enhancement be useful to most users
I believe that the power of jps will be accessible for way more users as soon as required data such as the geometry file can be easily converted from third party data sources. In addition the JOSM-Editor, which I find quite useful, provides well maintained and user-friendly editing tools based on vertices, just like jps.
If anyone is interested in what I#m doing, fell free to contact me. I'd be honored if it might someday help some users creating geometry files. Since my usecase are train stations, the code and especially the input parameters are very likely not well supporting other areas for now. If you're facing problems, let me know.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/184Quickest - Router: Suggestions on how to tackle problem2018-03-16T15:00:26+01:00Mohcine Chraibim.chraibi@fz-juelich.deQuickest - Router: Suggestions on how to tackle problem## Task ##
Inside of a room: Estimated Time of Arrival to a door, based on traffic/queues
## Current Solution (rough) ##
- searching for alternate routes
- searching for pedestrians in that room in front of alternate doors
- calc ETA
- ...## Task ##
Inside of a room: Estimated Time of Arrival to a door, based on traffic/queues
## Current Solution (rough) ##
- searching for alternate routes
- searching for pedestrians in that room in front of alternate doors
- calc ETA
- calc if current agent can break out of queue or is stuck inside
- change destination if possible
## Suggestion ##
- create a temp polygon of (ped-Pos, Door-Point-a, Door-Point-b)
- find other pedestrian that are inside polygon
- calc ETA from mean speed
### Pro ###
- using existing functions
- length of possible queue is respected
- similar to current solution
### Con ###
- calculation time grows with n^2+ (peds)
- similar to current solution
## Suggestion ##
- pedestrian have a counter
- pedestrian counter is reset when spawning or entering a new room
- while passing a door, the current counter (time-in-old-room) is stored as door-member
- estimate ETA by asking the door for last value of (time-in-old-room) of the ped that exited last
### Pro ###
- calculation does not grow with n^2
### Con ###
- last in queue will give door a bad rating, although queue is not there anymore.. (could be solved via door-member being a "soft"-state, that will reset after a few seconds)
**Please comment and/or post other Suggestions**https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/183GOALS are not 3d proof2018-03-16T15:00:26+01:00Mohcine Chraibim.chraibi@fz-juelich.deGOALS are not 3d proofgoals are defined without a z-coordinate.
As long as they are outside, we can assume, they are well-defined. Are goals allowed to be inside a building? (I think, they are. At least the program checks, if a pedestrian reached its goal ev...goals are defined without a z-coordinate.
As long as they are outside, we can assume, they are well-defined. Are goals allowed to be inside a building? (I think, they are. At least the program checks, if a pedestrian reached its goal even if he is inside.)
If so, we need to talk about that.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/182Discussion: Should we put all asserts, outputs and robustness-checks in #ifde...2018-03-16T15:00:26+01:00Mohcine Chraibim.chraibi@fz-juelich.deDiscussion: Should we put all asserts, outputs and robustness-checks in #ifdef DEBUG ... #endif blocksHey everyone,
I was thinking about the complexity of jpscore and all the stuff that is logged, bound-checked and stuff:
Some of that is done because of **good** defensive programming style, some is done to track the program or to find ...Hey everyone,
I was thinking about the complexity of jpscore and all the stuff that is logged, bound-checked and stuff:
Some of that is done because of **good** defensive programming style, some is done to track the program or to find bugs, etc..
I would like to ask you all, if we want to define one or two macros for conditional compilation (like **DEBUG** and/or **VERBOSE**, **ASSERT**) to but those checks, outputs and stuff in additional compilations and have a raw, fast compilation without all of them, once we verified the correctness of the program.
Example: While programming the ffRouter, I deal with several floor-fields (one for each room). If I query a direction and one of the two arguments (pedestrian, goal) is outside the floor-field, the result will be devastating (most likely a segfault).
So I do check in each query, if both arguments are valid. This will slow down the program. Once I know, the program-logic is correct, I could remove most of the checks - (at least most of the debug-output).
It is a (controversial) technique, to put those parts of a program in conditional blocks (``#ifdef KEYWORD``). What do you think about that?https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/156ORCA Model Exit strategy sensitivity2018-06-13T16:41:48+02:00Mohcine Chraibim.chraibi@fz-juelich.deORCA Model Exit strategy sensitivityThe ORCA model seems to be sensitive to the exit strategy as the preferred velocity is obtained from the exit point. At the moment the code works fine only for exit strategy 1 (tested using turning at corner model). It fails for other ex...The ORCA model seems to be sensitive to the exit strategy as the preferred velocity is obtained from the exit point. At the moment the code works fine only for exit strategy 1 (tested using turning at corner model). It fails for other exit strategies. Has anyone faced a similar issue in other models? @OSchmidts @chraibi @ArneMohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/127Which Router is functional?2018-08-28T22:25:08+02:00Mohcine Chraibim.chraibi@fz-juelich.deWhich Router is functional?The following router are available. Which one is still functional?
* [x] `global_shortest`
* OK. No errors.
* [ ] `local_shortest`
* not OK. behaves like `global_shortest`
* [x] `quickest`
* OK. Needs proper calibration. Par...The following router are available. Which one is still functional?
* [x] `global_shortest`
* OK. No errors.
* [ ] `local_shortest`
* not OK. behaves like `global_shortest`
* [x] `quickest`
* OK. Needs proper calibration. Parameters are hard coded
* [ ] `local_quickest`
* Not implemented.
* [x] `AI`
* OK
* [x] `ff_global_shortest`
* OK
* [ ] `ff_local_shortest`
* Not OK. behaves like `global_shortest`
* [x] `ff_quickest`
* OK (experimental, not calibrated, strangely synced agents)