• Ozaq's avatar
    Fix trivially fixable warnings (#411) · 01d7ea87
    Ozaq authored
    3/2 more serious warnigns on gcc/clang remain.
    
    A bunch of -Wdeprecated-copy warnings have been fixed
    E.g. class Point had explicit Copy C-tor which forces an implicit copy
    asignment operator. -Wdeprecated-copy complains about this. See rule of
    five.
    
    Several signed/unsigned comparisons could be removed by changing loop
    variables to size_t instead of int or unsigned int.
    
    Missing return statements added several functions.
    
    Several variable shadowing warnings have been fixed by renaming the
    shadowing variable.
    
    Unused parameters have been omited from function signatures so that no
    UNUSED macro is neccesary anymore. Also the macro has been removed since
    the lambda capture trick now triggers a warning on clang for an unused
    cpature. Since now all unused vars are gone I simply removed the macro.
    
    Some unneccesary const casts have been removed.
    01d7ea87
AgentsSourcesManager.cpp 22.2 KB