JPScore issueshttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues2018-06-13T16:41:22+02:00https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/20Parser2018-06-13T16:41:22+02:00Mohcine Chraibim.chraibi@fz-juelich.deParserDefault values for the parameters:Default values for the parameters:https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/26Cutoff radius2018-06-13T16:41:21+02:00Mohcine Chraibim.chraibi@fz-juelich.deCutoff radiusin Simulation.cpp the linkedcell size is compared to the cutoff radius of the GCFM.
```javascript
if(args->GetDistEffMaxPed()>args->GetLinkedCellSize()){
Log->Write...in Simulation.cpp the linkedcell size is compared to the cutoff radius of the GCFM.
```javascript
if(args->GetDistEffMaxPed()>args->GetLinkedCellSize()){
Log->Write("ERROR: the linked-cell size [%f] should be bigger than the force range
[%f]",args->GetLinkedCellSize(),args->GetDistEffMaxPed());
exit(EXIT_FAILURE);
}
```
make sure this is done for the Gompertz model.Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/48moscawa ini-files2018-06-13T16:29:20+02:00Mohcine Chraibim.chraibi@fz-juelich.demoscawa ini-filesThe following ini-files in inputfiles/moscawa:
1. ini-mall.xml
2. and ini.xml
have some router-issues. (duplicate router found)
The file ini-T.xml however is working fine.
Maybe this directory needs some cleaning?The following ini-files in inputfiles/moscawa:
1. ini-mall.xml
2. and ini.xml
have some router-issues. (duplicate router found)
The file ini-T.xml however is working fine.
Maybe this directory needs some cleaning?https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/29update xsd files in all xml inputs2018-06-13T16:29:20+02:00Mohcine Chraibim.chraibi@fz-juelich.deupdate xsd files in all xml inputswe need to validate the scheme of the inputfiles (ini, geometry, router, etc) bevor proceeding with the parsing
There are three files to validate:
ini.xml with xsi:noNamespaceSchemaLocation="http://xsd.jupedsim.org/jps_core.xsd"
ge...we need to validate the scheme of the inputfiles (ini, geometry, router, etc) bevor proceeding with the parsing
There are three files to validate:
ini.xml with xsi:noNamespaceSchemaLocation="http://xsd.jupedsim.org/jps_core.xsd"
geo.xml with xsi:noNamespaceSchemaLocation="http://xsd.jupedsim.org/jps_geometry.xsd"
routing.xml with xsi:noNamespaceSchemaLocation="http://xsd.jupedsim.org/jps_routing.xsd"
The content of all input files (in the directory demos and inputfiles) should be update accordinglyhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/76ordered Id of rooms and subrooms2018-06-13T16:29:20+02:00Mohcine Chraibim.chraibi@fz-juelich.deordered Id of rooms and subroomsrooms and subrooms should have continous IDs
0..1..2..3
moving from vector to maps will solved the issue.rooms and subrooms should have continous IDs
0..1..2..3
moving from vector to maps will solved the issue.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/77refactoring numCPU2018-06-13T16:29:20+02:00Mohcine Chraibim.chraibi@fz-juelich.derefactoring numCPU< numCPU >4</ numCPU >
should be changed to
< num_threads> 4 < / num_threads >< numCPU >4</ numCPU >
should be changed to
< num_threads> 4 < / num_threads >Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/72Seg Fault: Router2018-06-13T16:29:20+02:00Mohcine Chraibim.chraibi@fz-juelich.deSeg Fault: RouterSimulation with the quickest (local?) router is intereupted because of the Seg Fault.
Error Message is:
```
ERROR: No Transition or Crossing or hline with ID -1:
```
Ini file is
```
Utest/test_7.1/inifiles/ini_bug.xml
```
See Comm...Simulation with the quickest (local?) router is intereupted because of the Seg Fault.
Error Message is:
```
ERROR: No Transition or Crossing or hline with ID -1:
```
Ini file is
```
Utest/test_7.1/inifiles/ini_bug.xml
```
See Commit caa8b7eaahttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/68Distribute Pedestrians2018-06-13T16:29:19+02:00Mohcine Chraibim.chraibi@fz-juelich.deDistribute PedestriansIs failing!
See commit ccfb35582Is failing!
See commit ccfb35582https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/71Author names for v0.62018-06-13T16:29:19+02:00Mohcine Chraibim.chraibi@fz-juelich.deAuthor names for v0.6This issue is not technical but nevertheless important. Since, we have now more developers involved in this project, I find it good if somehow we could document it.
At the time beeing the only place where I could see author names is in ...This issue is not technical but nevertheless important. Since, we have now more developers involved in this project, I find it good if somehow we could document it.
At the time beeing the only place where I could see author names is in the guide.
Do you have any suggestions?https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/66obstacles and subrooms: attribute key "closed"2018-06-13T16:29:19+02:00Mohcine Chraibim.chraibi@fz-juelich.deobstacles and subrooms: attribute key "closed"what is the purpose of the attribute key "closed" when setting up obstacles and subrooms?
Especially for setting up obstacles, it seems to be mandatory but is not included in the documentation.what is the purpose of the attribute key "closed" when setting up obstacles and subrooms?
Especially for setting up obstacles, it seems to be mandatory but is not included in the documentation.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/64Documentation issues2018-06-13T16:29:19+02:00Mohcine Chraibim.chraibi@fz-juelich.deDocumentation issues1. page 22: geometry-file: missing "unit" entry
2. page 23: it is not obvious that subrooms are mandatory
3. routing-file: hint that either triangulation or hlines can be used in a project.
4. page 7: provide the location of the definiti...1. page 22: geometry-file: missing "unit" entry
2. page 23: it is not obvious that subrooms are mandatory
3. routing-file: hint that either triangulation or hlines can be used in a project.
4. page 7: provide the location of the definition files
5. page 25: inconsistencies between crossings and transitionshttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/63Agents parameters (velocities) on stairs2018-06-13T16:29:19+02:00Mohcine Chraibim.chraibi@fz-juelich.deAgents parameters (velocities) on stairsDifferent stairs types (staircase, escalator) ?Different stairs types (staircase, escalator) ?https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/57compilation with xcode generator2018-06-13T16:29:19+02:00Mohcine Chraibim.chraibi@fz-juelich.decompilation with xcode generator@kemloh: someone has to check this.@kemloh: someone has to check this.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/62option for showing the statistics in the xml input file2018-06-13T16:29:19+02:00Mohcine Chraibim.chraibi@fz-juelich.deoption for showing the statistics in the xml input file<show_statistics> </show_statistics><show_statistics> </show_statistics>https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/54plane equation variables are misleading.2018-06-13T16:29:19+02:00Mohcine Chraibim.chraibi@fz-juelich.deplane equation variables are misleading.Change to A_x, B_y, D
now they are A_x, B_y, C_z which might be misleading.
The expliyit equation is given by Z= Ax+ By+DChange to A_x, B_y, D
now they are A_x, B_y, C_z which might be misleading.
The expliyit equation is given by Z= Ax+ By+Dhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/52Update files version to v0.62018-06-13T16:29:19+02:00Mohcine Chraibim.chraibi@fz-juelich.deUpdate files version to v0.6Update all files version to v0.6 in preperation of the next releaseUpdate all files version to v0.6 in preperation of the next releasehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/51jpscore_compile failes when in source compiled2018-06-13T16:29:19+02:00Mohcine Chraibim.chraibi@fz-juelich.dejpscore_compile failes when in source compiledSome directories in CMakeLists.txt are not correctly set
```
--build-exe-dir ${EXECUTABLE_OUTPUT_PATH}
```Some directories in CMakeLists.txt are not correctly set
```
--build-exe-dir ${EXECUTABLE_OUTPUT_PATH}
```Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/39Test runtime2018-06-13T16:29:19+02:00Mohcine Chraibim.chraibi@fz-juelich.deTest runtimeMake test to check if code is getting slower.Make test to check if code is getting slower.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/24Router parameter2018-06-13T16:29:19+02:00Mohcine Chraibim.chraibi@fz-juelich.deRouter parameterIf router has no parameters,
```xml
<router router_id="2" description="quickest">
<parameters> ...If router has no parameters,
```xml
<router router_id="2" description="quickest">
<parameters>
<navigation_lines file="routing_obst.xml" />
</parameters>
</router>
```
than one should uncomment the `navigation_lines`-tag. Intuitively, I would say a user will uncomment the `parameters`-tag.
That leads to problems in parsing. For example in `GlobalRouter.cpp` this line should not assume the existence of the `parameters`-tag
```javascript
if (e->FirstChild("parameters")->FirstChildElement("navigation_lines"))
```https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/35Destination not found2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.deDestination not foundI think the simulation should not be run silently when such errors occur.
```ERROR: Cannot find valid destination for ped [4] located in room [1] subroom [0] going to destination [-1]```
Pedestrian is just removed.
Instead User sh...I think the simulation should not be run silently when such errors occur.
```ERROR: Cannot find valid destination for ped [4] located in room [1] subroom [0] going to destination [-1]```
Pedestrian is just removed.
Instead User should be informed.