JPScore issueshttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues2017-08-31T17:24:31+02:00https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/236Curve in Voronoi diagram2017-08-31T17:24:31+02:00Yao XiaoCurve in Voronoi diagramIn library boost Voronoi, how to get the curve of Voronoi edge in a Voronoi diagram including segments. And how to cut off the curve by geometry.
![issue](/uploads/7fd710ff9d6bbcd74b5a96d7705cf527/issue.png)In library boost Voronoi, how to get the curve of Voronoi edge in a Voronoi diagram including segments. And how to cut off the curve by geometry.
![issue](/uploads/7fd710ff9d6bbcd74b5a96d7705cf527/issue.png)https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/234Routing in Demo 42018-06-13T16:41:33+02:00Mohcine Chraibim.chraibi@fz-juelich.deRouting in Demo 4## Summary
Demo 4 does not work.
## Steps to reproduce
- Run
```
./bin/jpscore demos/scenario_4_stairs/stairs_ini.xml
```
Two runs are necessary:
- one run with `router_id="1"`
- and another with `router_id="2"`
- For the sake o...## Summary
Demo 4 does not work.
## Steps to reproduce
- Run
```
./bin/jpscore demos/scenario_4_stairs/stairs_ini.xml
```
Two runs are necessary:
- one run with `router_id="1"`
- and another with `router_id="2"`
- For the sake of testing change `number = "10"`
## Expected behavior
Pedestrians should evacuate
## Actual behavior
- With `router=2` they do not evacuate
- With `router=1` simulation breaks with error
## Inifile + Geometry file to reproduce bug
See `demos/scenario_4_stairs`
## Relevant logs, files (inifile and geometry) and/or screenshots
![router](/uploads/15d9c9789bb075adb17ec5254f2e3e1c/router.gif)
![Screen_Shot_2017-02-01_at_12.45.17](/uploads/02c703d2efd1ff93c7e278e16339cd3a/Screen_Shot_2017-02-01_at_12.45.17.png)arneArne GrafArne Grafhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/233Door Statstics2018-06-13T16:41:33+02:00Mohcine Chraibim.chraibi@fz-juelich.deDoor Statstics## Summary
Some pedestrians may have no `navLine` (How come?)
Therefore, when calling `UpdateFlowAtDoors()` the simulation will break at this [LINE](https://gitlab.version.fz-juelich.de/jupedsim/jpscore/blob/develop/Simulation.cpp#...## Summary
Some pedestrians may have no `navLine` (How come?)
Therefore, when calling `UpdateFlowAtDoors()` the simulation will break at this [LINE](https://gitlab.version.fz-juelich.de/jupedsim/jpscore/blob/develop/Simulation.cpp#L574) with a SegFault.
## Steps to reproduce
- add the following `<show_statistics>true</Show_statistics>` the inifile of [demo 7](https://gitlab.version.fz-juelich.de/jupedsim/jpscore/tree/develop/demos/scenario_7_floorfield)
- Run demo 7.
## Actual behavior
Segmentation Fault.
## Inifile + Geometry file to reproduce bug
[demo 7](https://gitlab.version.fz-juelich.de/jupedsim/jpscore/tree/develop/demos/scenario_7_floorfield)
## Relevant logs, files (inifile and geometry) and/or screenshots
![Screen_Shot_2017-01-25_at_12.51.17](/uploads/76ad92c724ccdd74b7047114044c4c2f/Screen_Shot_2017-01-25_at_12.51.17.png)Arne GrafArne Grafhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/232Calculate Voronoi Area2018-06-13T16:41:33+02:00Yao XiaoCalculate Voronoi AreaIn Branch: Xiao
`CalculatePolygonArea()` returns segFault.
`voronoinodes.size()` can be smaller than 3, but should not.In Branch: Xiao
`CalculatePolygonArea()` returns segFault.
`voronoinodes.size()` can be smaller than 3, but should not.Yao XiaoYao Xiaohttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/231Cleanup branches2018-06-13T16:41:33+02:00Mohcine Chraibim.chraibi@fz-juelich.deCleanup branches## What should be done
Clean up unused branches
## Why?
Too much unused branches is not good. For clarity and in order to not delete functionality we need to **cleanup**
## What should be done
Clean up unused branches
## Why?
Too much unused branches is not good. For clarity and in order to not delete functionality we need to **cleanup**
Arne GrafArne Grafhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/228The Euler scheme problem2017-05-19T08:58:39+02:00Mohcine Chraibim.chraibi@fz-juelich.deThe Euler scheme problemI got a problem about the computation of the Euler scheme, e.g. in GCFM model, the equation is
![image](/uploads/9ff0e42a3be3ea0fae1e68b3b8854e77/image.png)
![image](/uploads/9fa1b4195c2fafcdcfd44b2f9c492b8e/image.png)
if I use the v(t...I got a problem about the computation of the Euler scheme, e.g. in GCFM model, the equation is
![image](/uploads/9ff0e42a3be3ea0fae1e68b3b8854e77/image.png)
![image](/uploads/9fa1b4195c2fafcdcfd44b2f9c492b8e/image.png)
if I use the v(t) instead R(t) in the first equation, does this turn to be a first order ODE?
and I think Euler scheme is using to solve the first order ODE, and How to using it to solve the second order ODE.
Is there a derivation about how to using Euler scheme solve the first equation?
Thank you!https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/227Global_Shortest router: Pedestrian not finding its way! [Hochhaus]2019-01-29T09:29:14+01:00Mohcine Chraibim.chraibi@fz-juelich.deGlobal_Shortest router: Pedestrian not finding its way! [Hochhaus]![router](/uploads/231dd348d3e499ec0db4953ce025b7f5/router.gif)
Files used to reproduce this behavior are here [issue_global_shortest.zip](/uploads/6825a7eb659a07d0ca23fe7710cf5390/issue_global_shortest.zip)
- Pedestrian has `i...![router](/uploads/231dd348d3e499ec0db4953ce025b7f5/router.gif)
Files used to reproduce this behavior are here [issue_global_shortest.zip](/uploads/6825a7eb659a07d0ca23fe7710cf5390/issue_global_shortest.zip)
- Pedestrian has `id=69` lives in `Subroom=39` `Room=12`
- Branch: DevelopArne GrafArne Grafhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/226Output Bug - Writing part of output multiple times2017-08-31T17:24:32+02:00Mohcine Chraibim.chraibi@fz-juelich.deOutput Bug - Writing part of output multiple timesCould it be, that we should flush all buffers before entering a parallel section?
Found the following output - and I guess, it is written by each thread of a new entered parallel section. (No proof though)
```
INFO: Distributing 44 Ag...Could it be, that we should flush all buffers before entering a parallel section?
Found the following output - and I guess, it is written by each thread of a new entered parallel section. (No proof though)
```
INFO: Distributing 44 Agents in Room/Subrom [11/8]! Maximum allowed: 1763
...Done
INFO: Distributing 7 Agents in Room/Subrom [11/8]! Maximum allowed: 1719
...Done
INFO: Initializing the grid with cell size: 2.000000
INFO: Done with Initializing the grid
INFO: using CentrePointLocalFFViaFm in ffRouter::Init
imum allowed: 1719
umber="3" goal_id="0" router_id="1" />
<group group_id="10" agent_parameter_
INFO: using CentrePointLocalFFViaFm in ffRouter::Init
imum allowed: 1719
umber="3" goal_id="0" router_id="1" />
<group group_id="10" agent_parameter_
INFO: using CentrePointLocalFFViaFm in ffRouter::Init
imum allowed: 1719
umber="3" goal_id="0" router_id="1" />
<group group_id="10" agent_parameter_
INFO: using CentrePointLocalFFViaFm in ffRouter::Init
imum allowed: 1719
umber="3" goal_id="0" router_id="1" />
<group group_id="10" agent_parameter_
INFO: using CentrePointLocalFFViaFm in ffRouter::Init
imum allowed: 1719
umber="3" goal_id="0" router_id="1" />
<group group_id="10" agent_parameter_
INFO: using CentrePointLocalFFViaFm in ffRouter::Init
imum allowed: 1719
umber="3" goal_id="0" router_id="1" />
<group group_id="10" agent_parameter_
INFO: using CentrePointLocalFFViaFm in ffRouter::Init
imum allowed: 1719
umber="3" goal_id="0" router_id="1" />
<group group_id="10" agent_parameter_
INFO: using CentrePointLocalFFViaFm in ffRouter::Init
imum allowed: 1719
umber="3" goal_id="0" router_id="1" />
<group group_id="10" agent_parameter_
INFO: Adding distances in Room 12 to matrix
INFO: Adding distances in Room 8 to matrix
INFO: using CentrePointLocalFFViaFm in ffRouter::Init
INFO: Adding distances in Room 0 to matrix
INFO: using CentrePointLocalFFViaFm in ffRouter::Init
INFO: Adding distances in Room 6 to matrix
```https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/225Strategy 8 on Stairs2017-05-19T08:58:39+02:00Mohcine Chraibim.chraibi@fz-juelich.deStrategy 8 on StairsApparently Str 8 doe not work on Stairs.
Are the [restrictions](http://www.jupedsim.org/jpscore/2016-11-03-routing) formulated for the `ffrouter` the same for this strategy?Apparently Str 8 doe not work on Stairs.
Are the [restrictions](http://www.jupedsim.org/jpscore/2016-11-03-routing) formulated for the `ffrouter` the same for this strategy?Arne GrafArne Grafhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/224Compile errors under Windows (CLion)2017-05-19T08:58:39+02:00Mohcine Chraibim.chraibi@fz-juelich.deCompile errors under Windows (CLion)![image](/uploads/2d71c06ae350827026ad2084f155ca5d/image.png)![image](/uploads/2d71c06ae350827026ad2084f155ca5d/image.png)https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/223I've been compiled the Jpscore in visual studio 2013,but I got an error about...2017-05-19T08:58:39+02:00Mohcine Chraibim.chraibi@fz-juelich.deI've been compiled the Jpscore in visual studio 2013,but I got an error about the OpenMP![image](/uploads/29a22382295a0ded6dec0133b37541a4/image.png)
Can I just using "int" instead "size_t", I got that the VS2013 only support the OpenMP 2.0, and the OpenMP 2.0 doesn't allow the unsigned int in sentence "for".![image](/uploads/29a22382295a0ded6dec0133b37541a4/image.png)
Can I just using "int" instead "size_t", I got that the VS2013 only support the OpenMP 2.0, and the OpenMP 2.0 doesn't allow the unsigned int in sentence "for".https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/222Compiling error2017-05-19T08:58:39+02:00Mohcine Chraibim.chraibi@fz-juelich.deCompiling errorHello,
I get the attached error when compiling on opensuse 13.1 with gcc 4.8.3.
It would be great, if you have a suggestion how to fix this.
Thank you!
Best Regards
Fabian
[log_error](/uploads/5e176a33e7fee5eb60ae2da3e8bd276b/log_erro...Hello,
I get the attached error when compiling on opensuse 13.1 with gcc 4.8.3.
It would be great, if you have a suggestion how to fix this.
Thank you!
Best Regards
Fabian
[log_error](/uploads/5e176a33e7fee5eb60ae2da3e8bd276b/log_error)
[CMakeCache.txt](/uploads/b68c1dffba1dbc9dd55ebaba290948fa/CMakeCache.txt)https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/221Router Strategy combination2018-06-13T16:41:32+02:00Mohcine Chraibim.chraibi@fz-juelich.deRouter Strategy combinationGive a warning if case
- Router is "ff_global_shortest"
- and Strategy is NOT 8Give a warning if case
- Router is "ff_global_shortest"
- and Strategy is NOT 8https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/220f.mack's legacy2017-08-31T17:24:32+02:00Mohcine Chraibim.chraibi@fz-juelich.def.mack's legacyI have to geometry files I would like to share with you. You can use them for your own private testing or add them to the official tests.
"Equal distance" is a symmetric building. The two pedestrians (one commented out) should need the ...I have to geometry files I would like to share with you. You can use them for your own private testing or add them to the official tests.
"Equal distance" is a symmetric building. The two pedestrians (one commented out) should need the same time. I had some issue where this was not the case (one took the longer way).
"U shape" was to test the router (regarding the door hopping). The pedestrian should walk through the room and go back to the corridor (that is shorter than staying in the corridor).
Mohcine wants to make my report available to all of you. It contains some more documentation about the changes I made.
My branch parallel_ff will hopefully be merged soon into develop. Remember that it fixes the issues 213, 214, 215, and 218, so close them after merging.
[geometry_files.zip](/uploads/1dba1bff12e2ed06a51ac70ac9e2d2b2/geometry_files.zip)https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/219Segmentation Fault with router with defined Goals2018-06-13T16:41:32+02:00Mohcine Chraibim.chraibi@fz-juelich.deSegmentation Fault with router with defined GoalsUsing the following geometry
![Screen_Shot_2016-09-22_at_13.33.39](/uploads/696b032b2f8439a48a8dad809598bba5/Screen_Shot_2016-09-22_at_13.33.39.png)
with the following [inifile](/uploads/6359b037f90fe249989e9f9bb38cf739/inifile.xml) a...Using the following geometry
![Screen_Shot_2016-09-22_at_13.33.39](/uploads/696b032b2f8439a48a8dad809598bba5/Screen_Shot_2016-09-22_at_13.33.39.png)
with the following [inifile](/uploads/6359b037f90fe249989e9f9bb38cf739/inifile.xml) and [geometry](/uploads/1c882c4c28a7346afdc0ecc5bbcabeeb/xiao_geometry.xml) files with **the global router**
lead to "no route to destination" errors
![Screen_Shot_2016-09-22_at_13.36.48](/uploads/31f7c49502ced40d873f54c4e7e7a1c7/Screen_Shot_2016-09-22_at_13.36.48.png)
With the combo **FFrouter+ Strategy 9** leads to "out of bound error" + sporadic SegFaults.
![Screen_Shot_2016-09-22_at_13.38.18](/uploads/94feb6fbba0c612cd6f0fcc469d0b187/Screen_Shot_2016-09-22_at_13.38.18.png)
**Note** without specifying the attribute `goal_id` the simulation runs without problems. For the FF-router some oscillations are visible, though.Arne GrafArne Grafhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/218Thread safety of Router::FindExit()2017-08-31T17:24:32+02:00Mohcine Chraibim.chraibi@fz-juelich.deThread safety of Router::FindExit()In `Simulation::UpdateRoutesAndLocations()` (which calls `Pedestrian::FindRoute()`), `Router::FindExit()` is called without an `omp critical` construct, implying it is thread safe.
However, in `Pedestrian::Relocate()`, the call to `Rout...In `Simulation::UpdateRoutesAndLocations()` (which calls `Pedestrian::FindRoute()`), `Router::FindExit()` is called without an `omp critical` construct, implying it is thread safe.
However, in `Pedestrian::Relocate()`, the call to `Router::FindExit()` is inside a critical construct.
Either the critical construct is unnecessary (if all routers are thread safe) or it is missing in `Pedestrain::FindRoute()`.
This holds for the latest version at the time of writing (e9aeb106, I believe).https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/217Reduce timeout threshold for Jenkins test2018-06-13T16:41:31+02:00Mohcine Chraibim.chraibi@fz-juelich.deReduce timeout threshold for Jenkins testFor build 1073, runtest_juelich_3 took 3h until it timed out. The successful run in build 1074 only took 29s. Adjusting when a test in terminated would yield sooner results and reduce the load on the Jenkins machine.For build 1073, runtest_juelich_3 took 3h until it timed out. The successful run in build 1074 only took 29s. Adjusting when a test in terminated would yield sooner results and reduce the load on the Jenkins machine.Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/216Agents with different models2018-06-13T16:41:32+02:00Mohcine Chraibim.chraibi@fz-juelich.deAgents with different modelsSupply different pedestrian `groups` with different (operational) models, in order to compare within one single simulation different models.Supply different pedestrian `groups` with different (operational) models, in order to compare within one single simulation different models.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/215Store the result of dynamic_cast, if it is needed again2017-08-31T17:24:32+02:00Mohcine Chraibim.chraibi@fz-juelich.deStore the result of dynamic_cast, if it is needed againhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/214Use enums instead of bare integers2017-08-31T17:24:32+02:00Mohcine Chraibim.chraibi@fz-juelich.deUse enums instead of bare integersThis should make the code easier to read. Add to the list if you find any.
flags used in the floorfieldThis should make the code easier to read. Add to the list if you find any.
flags used in the floorfield