JPScore issueshttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues2018-06-13T16:41:47+02:00https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/109too many fixme and todo in the code2018-06-13T16:41:47+02:00Mohcine Chraibim.chraibi@fz-juelich.detoo many fixme and todo in the codeThere are tons of todo and fixme in the code.There are tons of todo and fixme in the code.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/118prepare commit: Astyle2018-06-13T16:41:47+02:00Mohcine Chraibim.chraibi@fz-juelich.deprepare commit: Astylerun astyle-script to format code according to a predefined style.
See for example
[prepare-commit.sh](https://github.com/qgis/QGIS/blob/master/scripts/prepare-commit.sh)run astyle-script to format code according to a predefined style.
See for example
[prepare-commit.sh](https://github.com/qgis/QGIS/blob/master/scripts/prepare-commit.sh)https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/107Implement the protocol buffer for trajectories as the binary-xml format2018-06-13T16:41:47+02:00Mohcine Chraibim.chraibi@fz-juelich.deImplement the protocol buffer for trajectories as the binary-xml formathttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/93Randomize Pedestrians using Mitchell’s best-candidate2018-06-13T16:41:46+02:00Mohcine Chraibim.chraibi@fz-juelich.deRandomize Pedestrians using Mitchell’s best-candidateMitchell’s best-candidate algorithm generates a new random sample by creating k candidate samples and picking the best of k. Here the “best” sample is defined as the sample that is farthest away from previous samples. The algorithm appro...Mitchell’s best-candidate algorithm generates a new random sample by creating k candidate samples and picking the best of k. Here the “best” sample is defined as the sample that is farthest away from previous samples. The algorithm approximates Poisson-disc sampling, producing a much more natural appearance (better blue noise spectral characteristics) than uniform random sampling.
See also the white-on-black and *Voronoi* variations of this example.
http://bl.ocks.org/mbostock/1893974https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/114time out for the grpc calls2018-06-13T16:41:46+02:00Mohcine Chraibim.chraibi@fz-juelich.detime out for the grpc callsThe programm should restart itself after a timeout during the grpc call when runnign in server modeThe programm should restart itself after a timeout during the grpc call when runnign in server modehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/147Clean up inifiles2018-06-13T16:41:46+02:00Mohcine Chraibim.chraibi@fz-juelich.deClean up inifilesAll inifiles in v0.8 should be running.
Please fix the ones not running or if you can't mention here which ones.All inifiles in v0.8 should be running.
Please fix the ones not running or if you can't mention here which ones.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/150JPSrunTest2018-06-13T16:41:46+02:00Mohcine Chraibim.chraibi@fz-juelich.deJPSrunTestshould look for jpsreport in the system directory. Important for jenkins.should look for jpsreport in the system directory. Important for jenkins.Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/80release process automation2018-06-13T16:41:45+02:00Mohcine Chraibim.chraibi@fz-juelich.derelease process automationSome steps of the release process can be automated.
Generating release builds,
generating Closed issues,
...Some steps of the release process can be automated.
Generating release builds,
generating Closed issues,
...https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/50Merge crossing and transitions2018-06-13T16:41:45+02:00Mohcine Chraibim.chraibi@fz-juelich.deMerge crossing and transitionsMerge crossing and transitions as a geometry simplification step.Merge crossing and transitions as a geometry simplification step.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/45progam should not quit within function (except main)2018-06-13T16:41:45+02:00Mohcine Chraibim.chraibi@fz-juelich.deprogam should not quit within function (except main)The program should only exit in the main function.
All other functions should return a Boolean value to indicate success of failureThe program should only exit in the main function.
All other functions should return a Boolean value to indicate success of failurehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/42Static route assignement2018-06-13T16:41:45+02:00Mohcine Chraibim.chraibi@fz-juelich.deStatic route assignementDefine a static route (escape route) pedestrians should follow.Define a static route (escape route) pedestrians should follow.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/90Tolerance setting for creating a Geometry2018-06-13T16:41:45+02:00Mohcine Chraibim.chraibi@fz-juelich.deTolerance setting for creating a GeometryWhile creating a Line (which is used in many places like exit line, wall etc), there is no check for the minimum distance between two points. There can be situations where Point P1(0,10) & Point P2(1E-5, 10). Would this create an issue f...While creating a Line (which is used in many places like exit line, wall etc), there is no check for the minimum distance between two points. There can be situations where Point P1(0,10) & Point P2(1E-5, 10). Would this create an issue for future/current implementations? In commercial CAD tools they use a minimum eps value below which any distance is considered as zero. Should there be a tolerance level check implemented for the Geometry creation?https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/267Pedestrians get in shapes2018-06-13T16:41:34+02:00Mohcine Chraibim.chraibi@fz-juelich.dePedestrians get in shapes## Short description of suggestion
The default shape of agents is `ellipse`.
In some models, the ellipse' semi-axes are chosen in a way, that we can even simulate *indirectly* `circles`.
It should be important to make proper (distan...## Short description of suggestion
The default shape of agents is `ellipse`.
In some models, the ellipse' semi-axes are chosen in a way, that we can even simulate *indirectly* `circles`.
It should be important to make proper (distance)calculations based on the agent's shape.
## Why would the enhancement be useful
The "hack" explained above comes at cost: Ellipse-calculations are expensive. So even, if the agents are circles, still expensive ellipse-functions e.g. for distance calculations are called.
Besides, it is important to be able to compare in a reproducible way the different possible shapes.
## How?
I suggest to introduce a class `shape`. Every agent *has* a `shape`. From this class derive two classes:
- `ellipse`
- `circles`
Other sub-classes can follow.tobias schroedtertobias schroedterhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/259Smoke Cue Model2018-06-13T16:41:34+02:00Mohcine Chraibim.chraibi@fz-juelich.deSmoke Cue Model## Short description of suggestion
- User defines a pre-movement time (e.g. 120 s)
- + detection time (e.g. 60s)
That means: the occupant remains in that position for 180 s regardless the occurrence of smoke or temperature.
It would b...## Short description of suggestion
- User defines a pre-movement time (e.g. 120 s)
- + detection time (e.g. 60s)
That means: the occupant remains in that position for 180 s regardless the occurrence of smoke or temperature.
It would be good if we can implement a function in the model that changes the pre-movement time of the occupant to 0 when the visibility drops to 10 m.
## Why would the enhancement be useful to most users
In this way, no weird results are obtained regarding people waiting in the smokeBen HeinBen Heinhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/232Calculate Voronoi Area2018-06-13T16:41:33+02:00Yao XiaoCalculate Voronoi AreaIn Branch: Xiao
`CalculatePolygonArea()` returns segFault.
`voronoinodes.size()` can be smaller than 3, but should not.In Branch: Xiao
`CalculatePolygonArea()` returns segFault.
`voronoinodes.size()` can be smaller than 3, but should not.Yao XiaoYao Xiaohttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/231Cleanup branches2018-06-13T16:41:33+02:00Mohcine Chraibim.chraibi@fz-juelich.deCleanup branches## What should be done
Clean up unused branches
## Why?
Too much unused branches is not good. For clarity and in order to not delete functionality we need to **cleanup**
## What should be done
Clean up unused branches
## Why?
Too much unused branches is not good. For clarity and in order to not delete functionality we need to **cleanup**
Arne GrafArne Grafhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/219Segmentation Fault with router with defined Goals2018-06-13T16:41:32+02:00Mohcine Chraibim.chraibi@fz-juelich.deSegmentation Fault with router with defined GoalsUsing the following geometry
![Screen_Shot_2016-09-22_at_13.33.39](/uploads/696b032b2f8439a48a8dad809598bba5/Screen_Shot_2016-09-22_at_13.33.39.png)
with the following [inifile](/uploads/6359b037f90fe249989e9f9bb38cf739/inifile.xml) a...Using the following geometry
![Screen_Shot_2016-09-22_at_13.33.39](/uploads/696b032b2f8439a48a8dad809598bba5/Screen_Shot_2016-09-22_at_13.33.39.png)
with the following [inifile](/uploads/6359b037f90fe249989e9f9bb38cf739/inifile.xml) and [geometry](/uploads/1c882c4c28a7346afdc0ecc5bbcabeeb/xiao_geometry.xml) files with **the global router**
lead to "no route to destination" errors
![Screen_Shot_2016-09-22_at_13.36.48](/uploads/31f7c49502ced40d873f54c4e7e7a1c7/Screen_Shot_2016-09-22_at_13.36.48.png)
With the combo **FFrouter+ Strategy 9** leads to "out of bound error" + sporadic SegFaults.
![Screen_Shot_2016-09-22_at_13.38.18](/uploads/94feb6fbba0c612cd6f0fcc469d0b187/Screen_Shot_2016-09-22_at_13.38.18.png)
**Note** without specifying the attribute `goal_id` the simulation runs without problems. For the FF-router some oscillations are visible, though.Arne GrafArne Grafhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/216Agents with different models2018-06-13T16:41:32+02:00Mohcine Chraibim.chraibi@fz-juelich.deAgents with different modelsSupply different pedestrian `groups` with different (operational) models, in order to compare within one single simulation different models.Supply different pedestrian `groups` with different (operational) models, in order to compare within one single simulation different models.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/189CppCheck2018-06-13T16:41:31+02:00Mohcine Chraibim.chraibi@fz-juelich.deCppCheckSomehow the trend is going in the wrong direction
![Screen_Shot_2016-05-03_at_14.45.15](/uploads/108cc6ea60f691a96d16b760fd0a37bf/Screen_Shot_2016-05-03_at_14.45.15.png)
Can somebody try to inverse this trend? :confused:Somehow the trend is going in the wrong direction
![Screen_Shot_2016-05-03_at_14.45.15](/uploads/108cc6ea60f691a96d16b760fd0a37bf/Screen_Shot_2016-05-03_at_14.45.15.png)
Can somebody try to inverse this trend? :confused:https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/173Pedestrians are too near to each other - simulation stopped - Quickest Path2018-06-13T16:41:30+02:00Mohcine Chraibim.chraibi@fz-juelich.dePedestrians are too near to each other - simulation stopped - Quickest PathWarning: in velocityModel
pedestrians are to near to ech other.
room "9" ; subroom "10"
[Ped_to_near.mp4](/uploads/94dad243a57b1e81082a5fa60a4e9599/Ped_to_near.mp4)
[sim_stop_quickest.rar](/uploads/781fd950a542c6d94d430917c2b59a68/sim_...Warning: in velocityModel
pedestrians are to near to ech other.
room "9" ; subroom "10"
[Ped_to_near.mp4](/uploads/94dad243a57b1e81082a5fa60a4e9599/Ped_to_near.mp4)
[sim_stop_quickest.rar](/uploads/781fd950a542c6d94d430917c2b59a68/sim_stop_quickest.rar)
![sim_stop_quickest](/uploads/14285ad61dbb6ebc0b5df4ddef20517b/sim_stop_quickest.jpg)Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.de