JPScore issueshttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues2018-05-09T12:20:18+02:00https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/273peds removed2018-05-09T12:20:18+02:00benjamin moehringpeds removedHi all,
a lot of peds in my obviously quite large simulation are removed directly after being inserted (4.500 out of 10.000). They do not show up in the trajectories.
This happens from second 30 on. If an agent is removed, all followin...Hi all,
a lot of peds in my obviously quite large simulation are removed directly after being inserted (4.500 out of 10.000). They do not show up in the trajectories.
This happens from second 30 on. If an agent is removed, all following agents, who were supposed to be inserted at the same time, are removed too. See the log:
> INFO: Source 159 generating 1 agents (0 remaining)
> INFO: Source 160 generating 1 agents (0 remaining)
> INFO: Source 161 generating 1 agents (0 remaining)
> INFO: Source 162 generating 1 agents (0 remaining)
> INFO: Source 163 generating 1 agents (0 remaining)
> INFO: Source 164 generating 1 agents (0 remaining)
> INFO: Source 165 generating 1 agents (0 remaining)
> WARNING: ped 160 with vmean 0.000000 has been deleted in room [39]/[3] after time 30.041667 s (current=30.083333
> WARNING: ped 161 with vmean 0.000000 has been deleted in room [39]/[2] after time 30.041667 s (current=30.083333
> WARNING: ped 162 with vmean 0.000000 has been deleted in room [1]/[12] after time 30.041667 s (current=30.083333
> WARNING: ped 163 with vmean 0.000000 has been deleted in room [29]/[14] after time 30.041667 s (current=30.083333
> WARNING: ped 164 with vmean 0.000000 has been deleted in room [2]/[11] after time 30.041667 s (current=30.083333
> WARNING: ped 165 with vmean 0.000000 has been deleted in room [53]/[6] after time 30.041667 s (current=30.083333
> INFO: Source 166 generating 1 agents (0 remaining)
> INFO: Source 167 generating 1 agents (0 remaining)
> INFO: Source 168 generating 1 agents (0 remaining)
> INFO: Source 169 generating 1 agents (0 remaining)
> INFO: Source 170 generating 1 agents (0 remaining)
> INFO: Source 171 generating 1 agents (0 remaining)
> INFO: Source 172 generating 1 agents (0 remaining)
> WARNING: ped 170 with vmean 0.000000 has been deleted in room [17]/[2] after time 31.083333 s (current=31.125000
> WARNING: ped 171 with vmean 0.000000 has been deleted in room [29]/[10] after time 31.083333 s (current=31.125000
> WARNING: ped 172 with vmean 0.000000 has been deleted in room [53]/[6] after time 31.083333 s (current=31.125000
In VelocityModel.cpp I found the relevant code:
` // stuck peds get removed. Warning is thrown. low speed due to jam is omitted.
if(ped->GetGlobalTime() > 30 + ped->GetPremovementTime() &&
std::max(ped->GetMeanVelOverRecTime(), ped->GetV().Norm()) < 0.01 &&
size == 0 ) // size length of peds neighbour vector
{
Log->Write("WARNING:\tped %d with vmean %f has been deleted in room [%i]/[%i] after time %f s (current=%f\n", ped->GetID(), ped->GetMeanVelOverRecTime(), ped->GetRoomID(), ped->GetSubRoomID(), ped->GetGlobalTime(), current);
#pragma omp critical(VelocityModel_ComputeNextTimeStep_pedsToRemove)
pedsToRemove.push_back(ped);
}`
What is the meaning of ped->GetPremovementTime() and is it possible that it should be set to a high value when agents are inserted from sources?
As I see it a ped, which is inserted after second 30, easily meets these demands.
How can we guarantee that these agents aren't immediately removed?
Thank you for your help.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/197ProgressBar slows down the simulation2018-05-01T08:24:57+02:00Mohcine Chraibim.chraibi@fz-juelich.deProgressBar slows down the simulationProgressBar slows down the simulation severly in some cases.
We test alternatives at the momentProgressBar slows down the simulation severly in some cases.
We test alternatives at the momenthttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/211Source thread hangs2018-05-01T08:23:25+02:00Mohcine Chraibim.chraibi@fz-juelich.deSource thread hangsMake sure, that the source thread terminates before the main thread.
To reproduce this case:
- set max sim time to a small number (10)
- set `v0` to 0
- set max agents in source to something high for example 50Make sure, that the source thread terminates before the main thread.
To reproduce this case:
- set max sim time to a small number (10)
- set `v0` to 0
- set max agents in source to something high for example 50https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/272Installation failed2018-05-01T08:16:29+02:00Ghost UserInstallation failedCmake Problem with commit a3ec1420
```
$ cmake ..
-- JPSCORE_VERSION: 0.8.2
-- BUILD_TESTING: OFF
-- BUILD_CPPUNIT_TEST: OFF
-- CMAKE_BUILD_TYPE: Debug
-- CMAKE_BINARY_DIR: /Users/anna/JuPedSim/jpscore/build
-- CMAKE_SOURCE_DIR: /User...Cmake Problem with commit a3ec1420
```
$ cmake ..
-- JPSCORE_VERSION: 0.8.2
-- BUILD_TESTING: OFF
-- BUILD_CPPUNIT_TEST: OFF
-- CMAKE_BUILD_TYPE: Debug
-- CMAKE_BINARY_DIR: /Users/anna/JuPedSim/jpscore/build
-- CMAKE_SOURCE_DIR: /Users/anna/JuPedSim/jpscore
-- CMAKE_TEST_DIR: /Users/anna/JuPedSim/jpscore/Utest
--
-- Platform:
-- Host: Darwin17.5.0x86_64
-- CMake: 3.10.2
-- CMake generator: Unix Makefiles
-- CMake build tool: /usr/bin/make
-- Configuration: Debug
--
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
-- Brew detected: /usr/local
-- Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES)
-- Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES)
-- Could NOT find OpenMP (missing: OpenMP_C_FOUND OpenMP_CXX_FOUND)
CMake Warning at /usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:801 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
/usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)
/usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:199 (find_package)
CMake Warning at /usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:801 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
/usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)
/usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:199 (find_package)
CMake Warning at /usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:801 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
/usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)
/usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:199 (find_package)
CMake Warning at /usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:801 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
/usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)
/usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:199 (find_package)
CMake Warning at /usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:801 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
/usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)
/usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:199 (find_package)
-- Boost version: 1.66.0
-- Found the following Boost libraries:
-- timer
-- chrono
-- system
-- filesystem
-- unit_test_framework
CMake Error at CMakeLists.txt:202 (find_package):
By not providing "FindCGAL.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "CGAL", but
CMake did not find one.
Could not find a package configuration file provided by "CGAL" with any of
the following names:
CGALConfig.cmake
cgal-config.cmake
Add the installation prefix of "CGAL" to CMAKE_PREFIX_PATH or set
"CGAL_DIR" to a directory containing one of the above files. If "CGAL"
provides a separate development package or SDK, be sure it has been
installed.
-- Configuring incomplete, errors occurred!
See also "/Users/anna/JuPedSim/jpscore/build/CMakeFiles/CMakeOutput.log".
```https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/269Agents not passing a transition2018-04-16T16:18:34+02:00benjamin moehringAgents not passing a transition## Summary
In the provided minimal example an agent isn't able to pass one of the transitions, while another agent passes the same transition in a different direction.
## Steps to reproduce
Run the example
## Inifile + Geometry file t...## Summary
In the provided minimal example an agent isn't able to pass one of the transitions, while another agent passes the same transition in a different direction.
## Steps to reproduce
Run the example
## Inifile + Geometry file to reproduce bug
[jps_geo.xml](/uploads/97d9f1e34b592c8b0ef4f8e63ac24235/jps_geo.xml)
[jps_ini.xml](/uploads/d18d16318f8c452f5514c36693af3535/jps_ini.xml)
## Relevant logs, files (inifile and geometry) and/or screenshots
[jps_log.P0.dat](/uploads/c8439717a78562c34e585e5f9464ba54/jps_log.P0.dat)
[jps_traj.xml](/uploads/c8fe5766d4c02249763fd05b3d732100/jps_traj.xml)
![image](/uploads/a01781270b513a254afb0b7c441bc04d/image.png)0.8.3Arne GrafArne Grafhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/9gcfm and gompertz behave differently when using the quickest path router2018-03-16T15:01:08+01:00Mohcine Chraibim.chraibi@fz-juelich.degcfm and gompertz behave differently when using the quickest path routermaybe unwanted interaction between the time in Jam and the velocity ??
if (v_neu.Norm() >= J_EPS_V){
ped->ResetTimeInJam();
}else{
ped->UpdateTimeInJam();
}maybe unwanted interaction between the time in Jam and the velocity ??
if (v_neu.Norm() >= J_EPS_V){
ped->ResetTimeInJam();
}else{
ped->UpdateTimeInJam();
}https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/10Unify Getv0(target) and GetV0() in one function2018-03-16T15:01:08+01:00Mohcine Chraibim.chraibi@fz-juelich.deUnify Getv0(target) and GetV0() in one functionWhen the target is near (```<J_EPS_GOAL```) do not calculate new desired direction. That is calling GetV0().
This can be incorporated in Getv0(target).When the target is near (```<J_EPS_GOAL```) do not calculate new desired direction. That is calling GetV0().
This can be incorporated in Getv0(target).https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/11Pedestrian's GetID(): Undefined id2018-03-16T15:01:08+01:00Mohcine Chraibim.chraibi@fz-juelich.dePedestrian's GetID(): Undefined idIn `ForceModel()` after deleting one pedestrian `subroom->DeletePedestrian(p)`, the function `ped->GetID()` returns undefined `id`, e.g. 1463697080In `ForceModel()` after deleting one pedestrian `subroom->DeletePedestrian(p)`, the function `ped->GetID()` returns undefined `id`, e.g. 1463697080https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/12QuickestpathRouter v==02018-03-16T15:01:08+01:00Mohcine Chraibim.chraibi@fz-juelich.deQuickestpathRouter v==0QPR exits with error if the reference pedestrians is standing `(v==0)`:
```cpp
//QuickestPathRouter.cpp L946
if(myref->GetV().Norm()==0.0){
Log->Write("ERROR:\t the...QPR exits with error if the reference pedestrians is standing `(v==0)`:
```cpp
//QuickestPathRouter.cpp L946
if(myref->GetV().Norm()==0.0){
Log->Write("ERROR:\t the reference pedestrian velocity is zero"); exit(0);
}
```
Pedestrians should be allowed to just not move.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/21Errors and warnings reportings2018-03-16T15:01:08+01:00Mohcine Chraibim.chraibi@fz-juelich.deErrors and warnings reportingsdifferences when using the log file and outputing to the consoledifferences when using the log file and outputing to the consolehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/22make use of the model id2018-03-16T15:01:08+01:00Mohcine Chraibim.chraibi@fz-juelich.demake use of the model idassign the model id to the agentsassign the model id to the agentshttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/46Uniform distribution of pedestrians2018-03-16T15:01:07+01:00Mohcine Chraibim.chraibi@fz-juelich.deUniform distribution of pedestriansMohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/56compilation with Visual Studio 12 (2013) generator2018-03-16T15:01:07+01:00Mohcine Chraibim.chraibi@fz-juelich.decompilation with Visual Studio 12 (2013) generatorI tried to compile again under windows with cmake-gui and the Visual Studio 2013 generator. CMake gives me the following output:
JPSCORE_VERSION: 0.5.0
BUILD_TESTING: OFF
PROCESSOR_COUNT: 8
CMAKE_BUILD_TYPE: Release
CMAKE_BINARY_DIR: C:...I tried to compile again under windows with cmake-gui and the Visual Studio 2013 generator. CMake gives me the following output:
JPSCORE_VERSION: 0.5.0
BUILD_TESTING: OFF
PROCESSOR_COUNT: 8
CMAKE_BUILD_TYPE: Release
CMAKE_BINARY_DIR: C:/Users/Oliver/Documents
CMAKE_SOURCE_DIR: C:/Users/Oliver/Documents/jpscore
Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
Checking for C++11 compiler - unavailable
Performing Test COMPILER_SUPPORTS_CXX11
Performing Test COMPILER_SUPPORTS_CXX11 - Failed
Performing Test COMPILER_SUPPORTS_CXX0X
Performing Test COMPILER_SUPPORTS_CXX0X - Failed
The compiler C:/Program Files (x86)/Microsoft Visual Studio 12.0/VC/bin/cl.exe has no C++11 support. Please use a different C++ compiler.
Release flags: /DWIN32 /D_WINDOWS /W3 /GR /EHsc /openmp , /MD /O2 /Ob2 /D NDEBUG
Configuring done
It says there is no c++11 support. However there is.
After generating the files i opened the solution file (*.sln) for visual studio. If i try to gernate this solution there are a total of 19 errors and 120 warnings. I post the errors. Most of them occur because of header files which are not found.
Fehler 1 error C1083: Datei (Include) kann nicht geöffnet werden: "bits/random.h": No such file or directory c:\users\oliver\documents\jpscore\routing\GlobalRouter.h 40 1
Fehler 2 error C1083: Datei (Include) kann nicht geöffnet werden: "getopt.h": No such file or directory C:\Users\Oliver\Documents\jpscore\general\ArgumentParser.cpp 28 1
Fehler 3 error C1083: Datei (Include) kann nicht geöffnet werden: "bits/random.h": No such file or directory c:\users\oliver\documents\jpscore\routing\GlobalRouter.h 40 1
Fehler 90 error C3016: "p": Die Indexvariable in der For-Anweisung von OpenMP muss einen ganzzahligen Typ mit Vorzeichen aufweisen. C:\Users\Oliver\Documents\jpscore\math\GPU_GCFMModel.cpp 546 1
Fehler 91 error C3016: "p": Die Indexvariable in der For-Anweisung von OpenMP muss einen ganzzahligen Typ mit Vorzeichen aufweisen. C:\Users\Oliver\Documents\jpscore\math\GPU_GCFMModel.cpp 588 1
Fehler 92 error C3016: "p": Die Indexvariable in der For-Anweisung von OpenMP muss einen ganzzahligen Typ mit Vorzeichen aufweisen. C:\Users\Oliver\Documents\jpscore\math\GPU_GCFMModel.cpp 822 1
Fehler 93 error C3016: "p": Die Indexvariable in der For-Anweisung von OpenMP muss einen ganzzahligen Typ mit Vorzeichen aufweisen. C:\Users\Oliver\Documents\jpscore\math\GPU_GCFMModel.cpp 837 1
Fehler 94 error C3016: "p": Die Indexvariable in der For-Anweisung von OpenMP muss einen ganzzahligen Typ mit Vorzeichen aufweisen. C:\Users\Oliver\Documents\jpscore\math\GPU_GCFMModel.cpp 877 1
Fehler 95 error C3016: "p": Die Indexvariable in der For-Anweisung von OpenMP muss einen ganzzahligen Typ mit Vorzeichen aufweisen. C:\Users\Oliver\Documents\jpscore\math\GPU_GCFMModel.cpp 928 1
Fehler 120 error C1083: Datei (Include) kann nicht geöffnet werden: "bits/random.h": No such file or directory c:\users\oliver\documents\jpscore\routing\GlobalRouter.h 40 1
Fehler 121 error C1083: Datei (Include) kann nicht geöffnet werden: "bits/random.h": No such file or directory c:\users\oliver\documents\jpscore\routing\GlobalRouter.h 40 1
Fehler 122 error C1083: Datei (Include) kann nicht geöffnet werden: "bits/random.h": No such file or directory c:\users\oliver\documents\jpscore\routing\GlobalRouter.h 40 1
Fehler 123 error C1083: Datei (Include) kann nicht geöffnet werden: "bits/random.h": No such file or directory c:\users\oliver\documents\jpscore\routing\GlobalRouter.h 40 1
Fehler 134 error C1083: Datei (Include) kann nicht geöffnet werden: "bits/random.h": No such file or directory c:\users\oliver\documents\jpscore\routing\GlobalRouter.h 40 1
135 IntelliSense: Die Datei "Quelle" kann nicht geöffnet werden: "getopt.h". c:\Users\Oliver\Documents\jpscore\general\ArgumentParser.cpp 28 1 core
136 IntelliSense: Die Datei "Quelle" kann nicht geöffnet werden: "unistd.h". c:\Users\Oliver\Documents\jpscore\general\ArgumentParser.cpp 29 1 core
137 IntelliSense: Die Datei "Quelle" kann nicht geöffnet werden: "bits/random.h". c:\Users\Oliver\Documents\jpscore\routing\GlobalRouter.h 40 1 corehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/58Results of Codeanalysis by Visual Studio, possible bugs and errors2018-03-16T15:01:07+01:00Mohcine Chraibim.chraibi@fz-juelich.deResults of Codeanalysis by Visual Studio, possible bugs and errorsthis should be fixed as soon as possible or if unused removed. sry for german error massages.
C6387 Ungültiger Parameterwert 'str' könnte '0' sein: dies entspricht nicht der Spezifikation für Funktion 'atoi'. core argumentparser.h 237...this should be fixed as soon as possible or if unused removed. sry for german error massages.
C6387 Ungültiger Parameterwert 'str' könnte '0' sein: dies entspricht nicht der Spezifikation für Funktion 'atoi'. core argumentparser.h 237
'str' kann NULL sein. (In diese Verzweigung eintreten) 237
'str' ist eine Eingabe für 'atoi' (in c:\program files (x86)\microsoft visual studio 12.0\vc\include\stdlib.h:430 deklariert) 237
'str' sollte nicht NULL sein, da dies nicht der SAL-Anmerkung zu 'atoi' entspricht. 237
C6387 Ungültiger Parameterwert 'str' könnte '0' sein: dies entspricht nicht der Spezifikation für Funktion 'atof'. core argumentparser.h 244
'str' kann NULL sein. (In diese Verzweigung eintreten) 244
'str' ist eine Eingabe für 'atof' (in c:\program files (x86)\microsoft visual studio 12.0\vc\include\math.h:527 deklariert) 244
'str' sollte nicht NULL sein, da dies nicht der SAL-Anmerkung zu 'atof' entspricht. 244
C6031 Rückgabewert wird ignoriert Rückgabewert wird ignoriert: 'getc'. core directionstrategy.cpp 108
C6031 Rückgabewert wird ignoriert Rückgabewert wird ignoriert: 'getc'. core directionstrategy.cpp 114
/*CRITICAL
C6011 Dereferenzierender NULL-Zeiger. Dereferenzierender NULL-Zeiger 'act_cell'. core meshrouter.cpp 581
'act_cell' kann NULL sein. 578
Diese Schleife überspringen (Annahme: '(bool)=i<*.size(), (), (bool)' ist false) 581
'act_cell' wird dereferenziert, kann jedoch weiterhin NULL sein. 581
/*CRITICAL
C28182 Dereferenzieren der Kopie eines NULL-Zeigers Dereferenzierender NULL-Zeiger. 'sub' enthält den gleichen NULL-Wert wie 'stair'. core navmesh.cpp 2471
'sub' kann NULL sein. (In diese Verzweigung eintreten) 2459
In diese Schleife eintreten (Annahme: '<Verzweigungsbedingung>') 2463
In diese Schleife eintreten (Annahme: 'k<r->GetNumberOfSubRooms()') 2465
In diese Verzweigung eintreten (Annahme: 'st!=0') 2469
'sub' wird dereferenziert, kann jedoch weiterhin NULL sein. 2471
C6031 Rückgabewert wird ignoriert Rückgabewert wird ignoriert: 'getc'. core pedestrian.cpp 666
/*CRITICAL
C28182 Dereferenzieren der Kopie eines NULL-Zeigers Dereferenzierender NULL-Zeiger. 'hline' enthält den gleichen NULL-Wert wie 'cros=dynamic_cast<Crossing *>hline, cros'. In Zeile 435 finden Sie einen früheren Ort, an dem dies vorkommen kann. core quickestpathrouter.cpp 443
'hline' wird dereferenziert, kann jedoch weiterhin NULL sein. 443
/*CRITICAL
C28182 Dereferenzieren der Kopie eines NULL-Zeigers Dereferenzierender NULL-Zeiger. 'hline' enthält den gleichen NULL-Wert wie 'cros=dynamic_cast<Crossing *>hline, cros'. In Zeile 524 finden Sie einen früheren Ort, an dem dies vorkommen kann. core quickestpathrouter.cpp 534
'hline' wird dereferenziert, kann jedoch weiterhin NULL sein. 534https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/59Unittests fail to compile with VS 20132018-03-16T15:01:07+01:00Mohcine Chraibim.chraibi@fz-juelich.deUnittests fail to compile with VS 2013Fehler 145 error C1083: Datei (Include) kann nicht geöffnet werden: "unistd.h": No such file or directory C:\Users\Oliver\Documents\jpscore\Utest\testClassPoint.cpp 39 1 testClassPoint
Fehler 146 error C1083: Datei (Include) kann nicht g...Fehler 145 error C1083: Datei (Include) kann nicht geöffnet werden: "unistd.h": No such file or directory C:\Users\Oliver\Documents\jpscore\Utest\testClassPoint.cpp 39 1 testClassPoint
Fehler 146 error C1083: Datei (Include) kann nicht geöffnet werden: "unistd.h": No such file or directory C:\Users\Oliver\Documents\jpscore\Utest\testClassLine.cpp 38 1 testClassLine
Fehler 147 error C1083: Datei (Include) kann nicht geöffnet werden: "unistd.h": No such file or directory C:\Users\Oliver\Documents\jpscore\Utest\testEffectiveDistanceToEllipse.cpp 39 1 testEffectiveDistanceToEllipse
Fehler 148 error C1083: Datei (Include) kann nicht geöffnet werden: "unistd.h": No such file or directory C:\Users\Oliver\Documents\jpscore\Utest\testEffectiveDistanceToLine.cpp 39 1 testEffectiveDistanceToLine
Fehler 149 error C1083: Datei (Include) kann nicht geöffnet werden: "unistd.h": No such file or directory C:\Users\Oliver\Documents\jpscore\Utest\testGetArea.cpp 39 1 testGetArea
Fehler 150 error C1083: Datei (Include) kann nicht geöffnet werden: "unistd.h": No such file or directory C:\Users\Oliver\Documents\jpscore\Utest\testIsInside.cpp 39 1 testIsInside
Fehler 151 error C1083: Datei (Include) kann nicht geöffnet werden: "unistd.h": No such file or directory C:\Users\Oliver\Documents\jpscore\Utest\testIsOn.cpp 39 1 testIsOn
Fehler 152 error C1083: Datei (Include) kann nicht geöffnet werden: "unistd.h": No such file or directory C:\Users\Oliver\Documents\jpscore\Utest\testIsOutside.cpp 39 1 testIsOutside
Fehler 153 error C1083: Datei (Include) kann nicht geöffnet werden: "unistd.h": No such file or directory C:\Users\Oliver\Documents\jpscore\Utest\testPointOnEllipse.cpp 39 1 testPointOnEllipse
reason is that unistd.h is only available for unix systems, maybe we can avoid this include?
Edit:
#ifdef WINDOWS
#include < direct.h >
#define GetCurrentDir _getcwd
#else
#include < unistd.h >
#define GetCurrentDir getcwd
#endif
WINDOWS seems not to be defined although i definitly use windows. maybe there is an error in cmake?Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/61VS2013 fails to compile after push2018-03-16T15:01:07+01:00Mohcine Chraibim.chraibi@fz-juelich.deVS2013 fails to compile after pushFehler 97 error C4716: 'Room::SetEgressTime': Muss einen Wert zurückgeben c:\users\oliver\documents\jpscore\geometry\room.cpp 133 1 core
Fehler 136 error C4716: 'QuickestPathRouter::GetTravelTime': Muss einen Wert zurückgeben c:\users\ol...Fehler 97 error C4716: 'Room::SetEgressTime': Muss einen Wert zurückgeben c:\users\oliver\documents\jpscore\geometry\room.cpp 133 1 core
Fehler 136 error C4716: 'QuickestPathRouter::GetTravelTime': Muss einen Wert zurückgeben c:\users\oliver\documents\jpscore\routing\quickestpathrouter.cpp 635 1 core
methods should be removed if not used, or return a value, or set to void.
It is 'only' a warning in g++ but an error in vs2013https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/69test 8 failing2018-03-16T15:01:06+01:00Mohcine Chraibim.chraibi@fz-juelich.detest 8 failinghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/70test 13 failing2018-03-16T15:01:06+01:00Mohcine Chraibim.chraibi@fz-juelich.detest 13 failinghttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/79Centralized documentation for the different modules2018-03-16T15:01:06+01:00Mohcine Chraibim.chraibi@fz-juelich.deCentralized documentation for the different modulesAll modules have their own wikis.
We should think of centralizing all this information.
The only way I can think of now, is to create another project documentation (or using the manual)...All modules have their own wikis.
We should think of centralizing all this information.
The only way I can think of now, is to create another project documentation (or using the manual)...https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/84Test 14 Fails2018-03-16T15:01:06+01:00Mohcine Chraibim.chraibi@fz-juelich.deTest 14 FailsSomewhere between these commits some calculations in jpscore changed... I found this because i was rewriting test 14 an took a look at the generated picture to see if my new test is ok. My Test seemed to fail because the picture differed...Somewhere between these commits some calculations in jpscore changed... I found this because i was rewriting test 14 an took a look at the generated picture to see if my new test is ok. My Test seemed to fail because the picture differed from the last generated one but in fact there is some change between the mentioned commits. However i cannot tell which commit lead to this change.
Author: Ulrich Kemloh <kemlohulrich@gmail.com>
Date: Tue Feb 3 18:09:22 2015 +0100
fixed: memory leak in agentsparameter
...
Author: Ulrich Kemloh <kemlohulrich@gmail.com>
Date: Thu Jan 29 13:35:54 2015 +0100
updating schema files