JPScore issueshttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues2018-01-19T15:00:01+01:00https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/261osm-convert: creating geometries from open data2018-01-19T15:00:01+01:00benjamin moehringosm-convert: creating geometries from open data## Short description of suggestion
Hello, I am currently developing a tool to convert openstreetmap data into jps-readable geometry.xml files.
You can check out the current version of my python code from https://github.com/bsmoehring/jps...## Short description of suggestion
Hello, I am currently developing a tool to convert openstreetmap data into jps-readable geometry.xml files.
You can check out the current version of my python code from https://github.com/bsmoehring/jpsTools
To be honest the code might still be unhandy for someone who didn't write it. But I provided some example datasets in https://github.com/bsmoehring/jpsTools/tree/master/jpsTools/osmImport/resources
## Why would the enhancement be useful to most users
I believe that the power of jps will be accessible for way more users as soon as required data such as the geometry file can be easily converted from third party data sources. In addition the JOSM-Editor, which I find quite useful, provides well maintained and user-friendly editing tools based on vertices, just like jps.
If anyone is interested in what I#m doing, fell free to contact me. I'd be honored if it might someday help some users creating geometry files. Since my usecase are train stations, the code and especially the input parameters are very likely not well supporting other areas for now. If you're facing problems, let me know.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/248Removing Dependencies on the directory-tree parsing (JPSfire)2018-03-22T17:31:39+01:00Arne GrafRemoving Dependencies on the directory-tree parsing (JPSfire)## Short description of suggestion
The directory-tree is parsed but when reading the files, the different paths get build with small paths-parts ("Z_") being hardcoded. Yet the shell script for creating these directories from JPSfire-Rep...## Short description of suggestion
The directory-tree is parsed but when reading the files, the different paths get build with small paths-parts ("Z_") being hardcoded. Yet the shell script for creating these directories from JPSfire-Repository ( https://gitlab.version.fz-juelich.de/jupedsim/jpsfire/blob/master/A_smoke_sensor/FDS/A_smoke_sensor/A_smoke_sensor.sh ) opens the possibility to have other prefixes.
## Why would the enhancement be useful to most users
There is no use-case in the demo-files, but it's likely to happen, once the smoke sensors get used more often.Arne GrafArne Grafhttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/185height of obstacles2018-03-16T15:00:26+01:00Mohcine Chraibim.chraibi@fz-juelich.deheight of obstaclesI am asking me the question if we could not define a height of obstacles.
Suppose we have an obstacle with a height of 1m (table). The obstacle will have an influence on the motion but not on the routing of an agent.
Maybe we could skip...I am asking me the question if we could not define a height of obstacles.
Suppose we have an obstacle with a height of 1m (table). The obstacle will have an influence on the motion but not on the routing of an agent.
Maybe we could skip these obstacles (up to a specific height) when the graph is set up?
This would avoid a lot of trouble with stuck agents in the most cases...Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/184Quickest - Router: Suggestions on how to tackle problem2018-03-16T15:00:26+01:00Mohcine Chraibim.chraibi@fz-juelich.deQuickest - Router: Suggestions on how to tackle problem## Task ##
Inside of a room: Estimated Time of Arrival to a door, based on traffic/queues
## Current Solution (rough) ##
- searching for alternate routes
- searching for pedestrians in that room in front of alternate doors
- calc ETA
- ...## Task ##
Inside of a room: Estimated Time of Arrival to a door, based on traffic/queues
## Current Solution (rough) ##
- searching for alternate routes
- searching for pedestrians in that room in front of alternate doors
- calc ETA
- calc if current agent can break out of queue or is stuck inside
- change destination if possible
## Suggestion ##
- create a temp polygon of (ped-Pos, Door-Point-a, Door-Point-b)
- find other pedestrian that are inside polygon
- calc ETA from mean speed
### Pro ###
- using existing functions
- length of possible queue is respected
- similar to current solution
### Con ###
- calculation time grows with n^2+ (peds)
- similar to current solution
## Suggestion ##
- pedestrian have a counter
- pedestrian counter is reset when spawning or entering a new room
- while passing a door, the current counter (time-in-old-room) is stored as door-member
- estimate ETA by asking the door for last value of (time-in-old-room) of the ped that exited last
### Pro ###
- calculation does not grow with n^2
### Con ###
- last in queue will give door a bad rating, although queue is not there anymore.. (could be solved via door-member being a "soft"-state, that will reset after a few seconds)
**Please comment and/or post other Suggestions**https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/182Discussion: Should we put all asserts, outputs and robustness-checks in #ifde...2018-03-16T15:00:26+01:00Mohcine Chraibim.chraibi@fz-juelich.deDiscussion: Should we put all asserts, outputs and robustness-checks in #ifdef DEBUG ... #endif blocksHey everyone,
I was thinking about the complexity of jpscore and all the stuff that is logged, bound-checked and stuff:
Some of that is done because of **good** defensive programming style, some is done to track the program or to find ...Hey everyone,
I was thinking about the complexity of jpscore and all the stuff that is logged, bound-checked and stuff:
Some of that is done because of **good** defensive programming style, some is done to track the program or to find bugs, etc..
I would like to ask you all, if we want to define one or two macros for conditional compilation (like **DEBUG** and/or **VERBOSE**, **ASSERT**) to but those checks, outputs and stuff in additional compilations and have a raw, fast compilation without all of them, once we verified the correctness of the program.
Example: While programming the ffRouter, I deal with several floor-fields (one for each room). If I query a direction and one of the two arguments (pedestrian, goal) is outside the floor-field, the result will be devastating (most likely a segfault).
So I do check in each query, if both arguments are valid. This will slow down the program. Once I know, the program-logic is correct, I could remove most of the checks - (at least most of the debug-output).
It is a (controversial) technique, to put those parts of a program in conditional blocks (``#ifdef KEYWORD``). What do you think about that?https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/38update parser to boost::propertytree2018-03-16T15:00:26+01:00Mohcine Chraibim.chraibi@fz-juelich.deupdate parser to boost::propertytreehttp://www.grinninglizard.com/tinyxml2docs/http://www.grinninglizard.com/tinyxml2docs/https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/35Destination not found2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.deDestination not foundI think the simulation should not be run silently when such errors occur.
```ERROR: Cannot find valid destination for ped [4] located in room [1] subroom [0] going to destination [-1]```
Pedestrian is just removed.
Instead User sh...I think the simulation should not be run silently when such errors occur.
```ERROR: Cannot find valid destination for ped [4] located in room [1] subroom [0] going to destination [-1]```
Pedestrian is just removed.
Instead User should be informed.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/32Help section2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.deHelp sectionRewrite the Help and command line parsing section.
Allowed should be:
jpscore.exe ini.xml
jpscore.exe --help [-h]
jpscore.exe --version [-v]
Do we still need the "--inifile/ --ini" since we only take input files as arguments?Rewrite the Help and command line parsing section.
Allowed should be:
jpscore.exe ini.xml
jpscore.exe --help [-h]
jpscore.exe --version [-v]
Do we still need the "--inifile/ --ini" since we only take input files as arguments?https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/19pMaxOpenMPThreads2018-06-13T16:41:22+02:00Mohcine Chraibim.chraibi@fz-juelich.depMaxOpenMPThreadsin `ArgumentParser` is not used.in `ArgumentParser` is not used.https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/8InitGlobalRouter()2018-06-13T16:29:17+02:00Mohcine Chraibim.chraibi@fz-juelich.deInitGlobalRouter()What a monster function is that?
From line 79 - to line 459!!
Is it possible to rewrite this function in such a way that iit becomes readble?What a monster function is that?
From line 79 - to line 459!!
Is it possible to rewrite this function in such a way that iit becomes readble?https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/6Exit strategies2018-06-13T16:29:18+02:00Mohcine Chraibim.chraibi@fz-juelich.deExit strategiesAll exit strategies (choosing the direction of the desired velocity) should be combined in a unique usable strategy.
One approach can be to adapt the strategy to the length of the portal.All exit strategies (choosing the direction of the desired velocity) should be combined in a unique usable strategy.
One approach can be to adapt the strategy to the length of the portal.Mohcine Chraibim.chraibi@fz-juelich.deMohcine Chraibim.chraibi@fz-juelich.dehttps://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/3Closed boundary conditions2018-06-13T16:41:45+02:00Mohcine Chraibim.chraibi@fz-juelich.deClosed boundary conditionsClosed boundary conditions should be implemented. Important for FD in 1dim (e.g. Rotunde) and 2dim (UG Hermes)Closed boundary conditions should be implemented. Important for FD in 1dim (e.g. Rotunde) and 2dim (UG Hermes)https://gitlab.jsc.fz-juelich.de/jupedsim/jpscore/-/issues/2Unified unit in all input and output files. Choose SI, metre for distances an...2018-06-13T16:41:22+02:00Mohcine Chraibim.chraibi@fz-juelich.deUnified unit in all input and output files. Choose SI, metre for distances and second for timeInput files currently are in Metres
Trajectories are in CentimetersInput files currently are in Metres
Trajectories are in Centimeters